RE: RFA: Fix build regression on 32-bit hosts [Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset]

["Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>]

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Ulrich Weigand
> Envoyé : lundi 16 septembre 2013 11:52
> À : Pierre Muller
> Cc : 'Jan Kratochvil'; 'Andreas Arnez'; gdb-patches@sourceware.org
> Objet : Re: RFA: Fix build regression on 32-bit hosts [Re: [RFA][PATCH v5
> 2/2] S/390: Add TDB regset]
> 
> Pierre Muller wrote:
> 
> > 2013-09-15  Pierre Muller  <muller@sourceware.org>
> >
> >         * arm-linux-tdep.c: Add "elf/common.h" header.
> >         Remove AT_HWCAP macro definintion as it is provided in
> >         added include file.
> >         * s390-tdep.c: Remove system header <elf.h>
> >         Add "elf/common.h" header for AT_HWCAP definition.
> >         (s390_core_read_description): Use correct CORE_ADDR
> >         for hwcap local variable used as third parameter
> >         of function target_auxv_search.
> 
> This is OK.  Sorry for the breakage!

  Patch committed,

Pierre Muller

PS:I think that system includes should be banned
in all files that are used for cross-debugging.

Example:
$ grep -E "include +<" *tdep.c
arm-linux-tdep.c:#include <ctype.h>
arm-tdep.c:#include <ctype.h>           /* XXX for isupper ().  */
i386-linux-tdep.c:#include <stdint.h>
i386-tdep.c:#include <stdint.h>
i386-tdep.c:#include <ctype.h>
ia64-libunwind-tdep.c:#include <dlfcn.h>
ia64-linux-tdep.c:#include <ctype.h>
linux-tdep.c:#include <ctype.h>
m32c-tdep.c:#include <stdarg.h>
m32c-tdep.c:#include <string.h>
mn10300-linux-tdep.c:#include <stdlib.h>
nto-tdep.c:#include <string.h>
nto-tdep.c:#include <sys/cygwin.h>
ppc-linux-tdep.c:#include <ctype.h>
rs6000-aix-tdep.c:#include <stddef.h>
rs6000-aix-tdep.c:#include <stdio.h>
rs6000-aix-tdep.c:#include <sys/ldr.h>
s390-tdep.c:#include <ctype.h>

But there are also other files
that do not end with tdep that are concerned...

Especially cases like <string.h> should be avoided as we do have
common/gdb_string.h...