From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3739 invoked by alias); 16 Sep 2013 11:35:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3730 invoked by uid 89); 16 Sep 2013 11:35:03 -0000 Received: from mailhost.u-strasbg.fr (HELO mailhost.u-strasbg.fr) (130.79.222.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Sep 2013 11:35:03 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_05,KHOP_THREADED,MSGID_MULTIPLE_AT autolearn=no version=3.3.2 X-HELO: mailhost.u-strasbg.fr Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antispam (Postfix) with ESMTP id D113F220D0D; Mon, 16 Sep 2013 13:34:59 +0200 (CEST) Received: from mailhost.u-strasbg.fr (localhost [127.0.0.1]) by antivirus (Postfix) with ESMTP id C1E6C220D5E; Mon, 16 Sep 2013 13:34:59 +0200 (CEST) Received: from md15.u-strasbg.fr (md15.u-strasbg.fr [130.79.200.204]) by mr1.u-strasbg.fr (Postfix) with ESMTP id 97C4B220D0D; Mon, 16 Sep 2013 13:34:57 +0200 (CEST) Received: from ms14.u-strasbg.fr (ms14.u-strasbg.fr [130.79.204.114]) by md15.u-strasbg.fr (8.14.3/jtpda-5.5pre1) with ESMTP id r8GBYvAB015821 ; Mon, 16 Sep 2013 13:34:57 +0200 (envelope-from pierre.muller@ics-cnrs.unistra.fr) Received: from E6510Muller (gw-ics.u-strasbg.fr [130.79.210.225]) (Authenticated sender: mullerp) by ms14.u-strasbg.fr (Postfix) with ESMTPSA id 0C70A1FD84; Mon, 16 Sep 2013 13:34:55 +0200 (CEST) From: "Pierre Muller" To: "'Ulrich Weigand'" Cc: References: <002701ceb25b$2e880fc0$8b982f40$@muller@ics-cnrs.unistra.fr> from "Pierre Muller" at Sep 15, 2013 11:33:08 PM <201309160951.r8G9pr5B021687@d06av02.portsmouth.uk.ibm.com> In-Reply-To: <201309160951.r8G9pr5B021687@d06av02.portsmouth.uk.ibm.com> Subject: RE: RFA: Fix build regression on 32-bit hosts [Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset] Date: Mon, 16 Sep 2013 11:35:00 -0000 Message-ID: <003e01ceb2d0$c5051770$4f0f4650$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-09/txt/msg00437.txt.bz2 > -----Message d'origine----- > De=A0: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] De la part de Ulrich Weigand > Envoy=E9=A0: lundi 16 septembre 2013 11:52 > =C0=A0: Pierre Muller > Cc=A0: 'Jan Kratochvil'; 'Andreas Arnez'; gdb-patches@sourceware.org > Objet=A0: Re: RFA: Fix build regression on 32-bit hosts [Re: [RFA][PATCH = v5 > 2/2] S/390: Add TDB regset] >=20 > Pierre Muller wrote: >=20 > > 2013-09-15 Pierre Muller > > > > * arm-linux-tdep.c: Add "elf/common.h" header. > > Remove AT_HWCAP macro definintion as it is provided in > > added include file. > > * s390-tdep.c: Remove system header > > Add "elf/common.h" header for AT_HWCAP definition. > > (s390_core_read_description): Use correct CORE_ADDR > > for hwcap local variable used as third parameter > > of function target_auxv_search. >=20 > This is OK. Sorry for the breakage! Patch committed, Pierre Muller PS:I think that system includes should be banned in all files that are used for cross-debugging. Example: $ grep -E "include +<" *tdep.c arm-linux-tdep.c:#include arm-tdep.c:#include /* XXX for isupper (). */ i386-linux-tdep.c:#include i386-tdep.c:#include i386-tdep.c:#include ia64-libunwind-tdep.c:#include ia64-linux-tdep.c:#include linux-tdep.c:#include m32c-tdep.c:#include m32c-tdep.c:#include mn10300-linux-tdep.c:#include nto-tdep.c:#include nto-tdep.c:#include ppc-linux-tdep.c:#include rs6000-aix-tdep.c:#include rs6000-aix-tdep.c:#include rs6000-aix-tdep.c:#include s390-tdep.c:#include But there are also other files that do not end with tdep that are concerned... Especially cases like should be avoided as we do have common/gdb_string.h...