From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: arnez@linux.vnet.ibm.com (Andreas Arnez)
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset
Date: Fri, 13 Sep 2013 12:42:00 -0000 [thread overview]
Message-ID: <201309131242.r8DCg0r9020703@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <87sixbfkb6.fsf@br87z6lw.de.ibm.com> from "Andreas Arnez" at Sep 11, 2013 05:29:49 PM
Andreas Arnez wrote:
> gdb/ChangeLog:
> 2013-09-11 Andreas Arnez <arnez@linux.vnet.ibm.com>
>
> * NEWS: Mention TDB support.
> * features/s390-tdb.xml: New file.
> * features/s390-te-linux64.xml: New file.
> * features/s390x-te-linux64.xml: New file.
> * features/Makefile (WHICH): Add new tdescs above.
> (s390-te-linux64-expedite): Set.
> (s390x-te-linux64-expedite): Set.
> * features/s390-te-linux64.c: New file (generated).
> * features/s390x-te-linux64.c: New file (generated).
> * regformats/s390-te-linux64.dat: New file (generated).
> * regformats/s390x-te-linux64.dat: New file (generated).
> * s390-tdep.h (HWCAP_S390_HIGH_GPRS): Define.
> (HWCAP_S390_TE): Likewise.
> (S390_TDB_DWORD0_REGNUM): Likewise.
> (S390_TDB_DWORD0_REGNUM): Likewise.
> (S390_TDB_ABORT_CODE_REGNUM): Likewise.
> (S390_TDB_CONFLICT_TOKEN_REGNUM): Likewise.
> (S390_TDB_ATIA_REGNUM): Likewise.
> (S390_TDB_R0_REGNUM): Likewise.
> (S390_TDB_R1_REGNUM): Likewise.
> (S390_TDB_R2_REGNUM): Likewise.
> (S390_TDB_R3_REGNUM): Likewise.
> (S390_TDB_R4_REGNUM): Likewise.
> (S390_TDB_R5_REGNUM): Likewise.
> (S390_TDB_R6_REGNUM): Likewise.
> (S390_TDB_R7_REGNUM): Likewise.
> (S390_TDB_R8_REGNUM): Likewise.
> (S390_TDB_R9_REGNUM): Likewise.
> (S390_TDB_R10_REGNUM): Likewise.
> (S390_TDB_R11_REGNUM): Likewise.
> (S390_TDB_R12_REGNUM): Likewise.
> (S390_TDB_R13_REGNUM): Likewise.
> (S390_TDB_R14_REGNUM): Likewise.
> (S390_TDB_R15_REGNUM): Likewise.
> (S390_NUM_REGS): Increase.
> (S390_IS_TDBREGSET_REGNUM): New macro.
> (s390_regmap_tdb): Declare.
> (s390_sizeof_tdbregset): Define.
> (tdesc_s390_te_linux64): Declare.
> (tdesc_s390x_te_linux64): Likewise.
> * s390-tdep.c: Add includes for "auxv.h", <elf.h>,
> "features/s390-te-linux64.c", and "features/s390x-te-linux64.c".
> (s390_regmap_tdb): New regmap.
> (s390_supply_tdb_regset): New function.
> (s390_tdb_regset): New regset.
> (s390_linux64v2_regset_sections): Add TDB regset to list.
> (s390x_linux64v2_regset_sections): Likewise.
> (s390_regset_from_core_section): Recognize TDB core note section.
> (s390_core_read_description): If HWCAP indicates TE support,
> select tdesc_s390_te_linux64 or tdesc_s390_s390x_te_linux64.
> (s390_gdbarch_init): Handle TDB regset.
> (_initialize_s390_tdep): Initialize new tdescs.
> * s390-nat.c (HWCAP_S390_HIGH_GPRS): Remove define.
> (have_regset_tdb): New variable.
> (s390_native_supply): Support register invalidation.
> (fetch_regset): Invalidate registers if ptrace yields ENODATA.
> (check_regset): Treat ENODATA as "regset exists".
> (s390_linux_fetch_inferior_registers): Add TDB.
> (s390_read_description): Check for TDB existence and select
> appropriate tdesc.
> * gdbserver/Makefile.in (clean): Add removal of new makefile
> targets.
> (s390-te-linux64.c): New makefile target.
> (s390x-te-linux64.c): Likewise.
> * gdbserver/configure.srv (srv_regobj): Append new objects
> s390-te-linux64.o and s390x-te-linux64.o.
> (srv_xmlfiles): Append new files s390-te-linux64.xml,
> s390x-te-linux64.xml, and s390-tdb.xml.
> * gdbserver/linux-s390-low.c (init_registers_s390_te_linux64): New
> declaration.
> (tdesc_s390_te_linux64): Likewise.
> (init_registers_s390x_te_linux64): Likewise.
> (tdesc_s390x_te_linux64): Likewise.
> (s390_check_regset): Treat ENODATA as "regset exists".
> (s390_arch_setup): Add TDB regset support.
> (initialize_low_arch): Initialize registers for new tdescs.
>
> gdb/doc/ChangeLog:
> 2013-09-11 Andreas Arnez <arnez@linux.vnet.ibm.com>
>
> * gdb.texinfo (Decimal Floating Point format): Mention S/390.
> (Standard Target Features): Add new node to menu.
> (S/390 and System z Features): New node.
>
> gdb/testsuite/ChangeLog:
> 2013-09-11 Andreas Arnez <arnez@linux.vnet.ibm.com>
>
> * gdb.arch/s390-tdbregs.c: New file.
> * gdb.arch/s390-tdbregs.exp: New file.
This is OK with the latest version of the doc changes
as approved by Eli.
Can you send me a complete final version; I'll check it in.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2013-09-13 12:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 15:15 [RFA][PATCH v5 0/2] S/390: Add TDB regset support Andreas Arnez
2013-09-11 15:29 ` [RFA][PATCH v5 1/2] S/390 regmap rework Andreas Arnez
2013-09-13 12:40 ` Ulrich Weigand
2013-09-11 15:30 ` [RFA][PATCH v5 2/2] S/390: Add TDB regset Andreas Arnez
2013-09-11 16:28 ` Eli Zaretskii
2013-09-11 16:55 ` Andreas Arnez
2013-09-11 16:59 ` Eli Zaretskii
2013-09-11 17:39 ` Andreas Arnez
2013-09-11 19:21 ` Eli Zaretskii
2013-09-13 12:42 ` Ulrich Weigand [this message]
2013-09-15 15:52 ` Build regression on 32-bit hosts [Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset] Jan Kratochvil
2013-09-15 21:33 ` RFA: Fix build " Pierre Muller
2013-09-16 9:52 ` Ulrich Weigand
2013-09-16 11:35 ` Pierre Muller
2013-09-16 12:23 ` Joel Brobecker
2013-09-16 13:53 ` Eli Zaretskii
[not found] ` <38466.0263116986$1379331313@news.gmane.org>
2013-09-17 18:39 ` Tom Tromey
2013-09-16 10:43 ` Andreas Arnez
2013-09-12 15:36 ` [RFA][PATCH v5 0/2] S/390: Add TDB regset support Andreas Arnez
2013-09-13 14:19 ` Ulrich Weigand
2013-09-15 14:42 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309131242.r8DCg0r9020703@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox