From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21821 invoked by alias); 13 Sep 2013 12:42:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21812 invoked by uid 89); 13 Sep 2013 12:42:09 -0000 Received: from e06smtp17.uk.ibm.com (HELO e06smtp17.uk.ibm.com) (195.75.94.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 13 Sep 2013 12:42:09 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD,SPF_SOFTFAIL autolearn=ham version=3.3.2 X-HELO: e06smtp17.uk.ibm.com Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Sep 2013 13:36:42 +0100 Received: from d06dlp03.portsmouth.uk.ibm.com (9.149.20.15) by e06smtp17.uk.ibm.com (192.168.101.147) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 13 Sep 2013 13:36:40 +0100 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 79CE21B08067 for ; Fri, 13 Sep 2013 13:42:03 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8DCfo1D43515950 for ; Fri, 13 Sep 2013 12:41:50 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r8DCg1sd020794 for ; Fri, 13 Sep 2013 06:42:02 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id r8DCg0r9020703; Fri, 13 Sep 2013 06:42:00 -0600 Message-Id: <201309131242.r8DCg0r9020703@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 13 Sep 2013 14:42:00 +0200 Subject: Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset To: arnez@linux.vnet.ibm.com (Andreas Arnez) Date: Fri, 13 Sep 2013 12:42:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <87sixbfkb6.fsf@br87z6lw.de.ibm.com> from "Andreas Arnez" at Sep 11, 2013 05:29:49 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13091312-0542-0000-0000-000006702B68 X-SW-Source: 2013-09/txt/msg00399.txt.bz2 Andreas Arnez wrote: > gdb/ChangeLog: > 2013-09-11 Andreas Arnez > > * NEWS: Mention TDB support. > * features/s390-tdb.xml: New file. > * features/s390-te-linux64.xml: New file. > * features/s390x-te-linux64.xml: New file. > * features/Makefile (WHICH): Add new tdescs above. > (s390-te-linux64-expedite): Set. > (s390x-te-linux64-expedite): Set. > * features/s390-te-linux64.c: New file (generated). > * features/s390x-te-linux64.c: New file (generated). > * regformats/s390-te-linux64.dat: New file (generated). > * regformats/s390x-te-linux64.dat: New file (generated). > * s390-tdep.h (HWCAP_S390_HIGH_GPRS): Define. > (HWCAP_S390_TE): Likewise. > (S390_TDB_DWORD0_REGNUM): Likewise. > (S390_TDB_DWORD0_REGNUM): Likewise. > (S390_TDB_ABORT_CODE_REGNUM): Likewise. > (S390_TDB_CONFLICT_TOKEN_REGNUM): Likewise. > (S390_TDB_ATIA_REGNUM): Likewise. > (S390_TDB_R0_REGNUM): Likewise. > (S390_TDB_R1_REGNUM): Likewise. > (S390_TDB_R2_REGNUM): Likewise. > (S390_TDB_R3_REGNUM): Likewise. > (S390_TDB_R4_REGNUM): Likewise. > (S390_TDB_R5_REGNUM): Likewise. > (S390_TDB_R6_REGNUM): Likewise. > (S390_TDB_R7_REGNUM): Likewise. > (S390_TDB_R8_REGNUM): Likewise. > (S390_TDB_R9_REGNUM): Likewise. > (S390_TDB_R10_REGNUM): Likewise. > (S390_TDB_R11_REGNUM): Likewise. > (S390_TDB_R12_REGNUM): Likewise. > (S390_TDB_R13_REGNUM): Likewise. > (S390_TDB_R14_REGNUM): Likewise. > (S390_TDB_R15_REGNUM): Likewise. > (S390_NUM_REGS): Increase. > (S390_IS_TDBREGSET_REGNUM): New macro. > (s390_regmap_tdb): Declare. > (s390_sizeof_tdbregset): Define. > (tdesc_s390_te_linux64): Declare. > (tdesc_s390x_te_linux64): Likewise. > * s390-tdep.c: Add includes for "auxv.h", , > "features/s390-te-linux64.c", and "features/s390x-te-linux64.c". > (s390_regmap_tdb): New regmap. > (s390_supply_tdb_regset): New function. > (s390_tdb_regset): New regset. > (s390_linux64v2_regset_sections): Add TDB regset to list. > (s390x_linux64v2_regset_sections): Likewise. > (s390_regset_from_core_section): Recognize TDB core note section. > (s390_core_read_description): If HWCAP indicates TE support, > select tdesc_s390_te_linux64 or tdesc_s390_s390x_te_linux64. > (s390_gdbarch_init): Handle TDB regset. > (_initialize_s390_tdep): Initialize new tdescs. > * s390-nat.c (HWCAP_S390_HIGH_GPRS): Remove define. > (have_regset_tdb): New variable. > (s390_native_supply): Support register invalidation. > (fetch_regset): Invalidate registers if ptrace yields ENODATA. > (check_regset): Treat ENODATA as "regset exists". > (s390_linux_fetch_inferior_registers): Add TDB. > (s390_read_description): Check for TDB existence and select > appropriate tdesc. > * gdbserver/Makefile.in (clean): Add removal of new makefile > targets. > (s390-te-linux64.c): New makefile target. > (s390x-te-linux64.c): Likewise. > * gdbserver/configure.srv (srv_regobj): Append new objects > s390-te-linux64.o and s390x-te-linux64.o. > (srv_xmlfiles): Append new files s390-te-linux64.xml, > s390x-te-linux64.xml, and s390-tdb.xml. > * gdbserver/linux-s390-low.c (init_registers_s390_te_linux64): New > declaration. > (tdesc_s390_te_linux64): Likewise. > (init_registers_s390x_te_linux64): Likewise. > (tdesc_s390x_te_linux64): Likewise. > (s390_check_regset): Treat ENODATA as "regset exists". > (s390_arch_setup): Add TDB regset support. > (initialize_low_arch): Initialize registers for new tdescs. > > gdb/doc/ChangeLog: > 2013-09-11 Andreas Arnez > > * gdb.texinfo (Decimal Floating Point format): Mention S/390. > (Standard Target Features): Add new node to menu. > (S/390 and System z Features): New node. > > gdb/testsuite/ChangeLog: > 2013-09-11 Andreas Arnez > > * gdb.arch/s390-tdbregs.c: New file. > * gdb.arch/s390-tdbregs.exp: New file. This is OK with the latest version of the doc changes as approved by Eli. Can you send me a complete final version; I'll check it in. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com