Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset
Date: Wed, 11 Sep 2013 16:28:00 -0000	[thread overview]
Message-ID: <83sixbiaqe.fsf@gnu.org> (raw)
In-Reply-To: <87sixbfkb6.fsf@br87z6lw.de.ibm.com>

> From: Andreas Arnez <arnez@linux.vnet.ibm.com>
> Date: Wed, 11 Sep 2013 17:29:49 +0200
> 
> --- gdb.orig/gdb/NEWS
> +++ gdb/gdb/NEWS
> @@ -111,6 +111,10 @@ show range-stepping
>  * GDB now understands the element 'tvar' in the XML traceframe info.
>    It has the id of the collected trace state variables.
>  
> +* On S/390 targets that provide the transactional-execution feature,
> +  the program interruption transaction diagnostic block (TDB) is now
> +  represented as a number of additional "registers" in GDB.

This part is OK, but the manual should cover this in more detail; I
see no reference to "TDB" in your patch for the manual.  So the reader
of this NEWS entry will be unable to find any details about this new
feature.

> --- gdb.orig/gdb/doc/gdb.texinfo
> +++ gdb/gdb/doc/gdb.texinfo

This part is also OK, except for the above comment.

Thanks.


  reply	other threads:[~2013-09-11 16:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 15:15 [RFA][PATCH v5 0/2] S/390: Add TDB regset support Andreas Arnez
2013-09-11 15:29 ` [RFA][PATCH v5 1/2] S/390 regmap rework Andreas Arnez
2013-09-13 12:40   ` Ulrich Weigand
2013-09-11 15:30 ` [RFA][PATCH v5 2/2] S/390: Add TDB regset Andreas Arnez
2013-09-11 16:28   ` Eli Zaretskii [this message]
2013-09-11 16:55     ` Andreas Arnez
2013-09-11 16:59       ` Eli Zaretskii
2013-09-11 17:39         ` Andreas Arnez
2013-09-11 19:21           ` Eli Zaretskii
2013-09-13 12:42   ` Ulrich Weigand
2013-09-15 15:52     ` Build regression on 32-bit hosts [Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset] Jan Kratochvil
2013-09-15 21:33       ` RFA: Fix build " Pierre Muller
2013-09-16  9:52         ` Ulrich Weigand
2013-09-16 11:35           ` Pierre Muller
2013-09-16 12:23             ` Joel Brobecker
2013-09-16 13:53               ` Eli Zaretskii
     [not found]           ` <38466.0263116986$1379331313@news.gmane.org>
2013-09-17 18:39             ` Tom Tromey
2013-09-16 10:43         ` Andreas Arnez
2013-09-12 15:36 ` [RFA][PATCH v5 0/2] S/390: Add TDB regset support Andreas Arnez
2013-09-13 14:19 ` Ulrich Weigand
2013-09-15 14:42   ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sixbiaqe.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=arnez@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox