From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6422 invoked by alias); 16 Sep 2013 12:23:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6406 invoked by uid 89); 16 Sep 2013 12:23:49 -0000 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 16 Sep 2013 12:23:49 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 730471164C2; Mon, 16 Sep 2013 08:24:00 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id O0BoHjUnWKDd; Mon, 16 Sep 2013 08:24:00 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 41F3E1164BA; Mon, 16 Sep 2013 08:24:00 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 96A85E2073; Mon, 16 Sep 2013 05:23:45 -0700 (PDT) Date: Mon, 16 Sep 2013 12:23:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: 'Ulrich Weigand' , gdb-patches@sourceware.org Subject: Re: RFA: Fix build regression on 32-bit hosts [Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset] Message-ID: <20130916122345.GA3132@adacore.com> References: <002701ceb25b$2e880fc0$8b982f40$@muller@ics-cnrs.unistra.fr> <201309160951.r8G9pr5B021687@d06av02.portsmouth.uk.ibm.com> <003e01ceb2d0$c5051770$4f0f4650$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <003e01ceb2d0$c5051770$4f0f4650$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-09/txt/msg00438.txt.bz2 > PS:I think that system includes should be banned > in all files that are used for cross-debugging. This is already the main idea, except that we cannot banish all system includes. For instance, includes that are part of the C standard are OK (ctype.h, stdint.h, stdarg.h, etc) are fine. Others, such as dlfcn.h or sys/cygwin.h, on the other hand, are not. > Especially cases like should be avoided as we do have > common/gdb_string.h... Agreed on this one. -- Joel