Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aleksandar Ristovski <aristovski@qnx.com>
To: gdb-patches@sourceware.org
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] cleanup: Wunused - amd64
Date: Mon, 01 Apr 2013 12:26:00 -0000	[thread overview]
Message-ID: <51597CC0.6030408@qnx.com> (raw)
Message-ID: <20130401122600.DHY5foRYOG176-UbdW2JqgQiwR9pdEfTM8p6OV4PLkk@z> (raw)
In-Reply-To: <20130329002606.GG4758@adacore.com>

On 13-03-28 08:26 PM, Joel Brobecker wrote:
>>    Aleksandar Ristovski  <aristovski@qnx.com>
>>
>>       * amd64-tdep.c (fixup_riprel): Remove unused BYTE_ORDER, DISP.
>
> Was this ever reviewed? If not, I apologize. Approved.
>

Tom has expressed concerns about removing 'disp', and I haven't had time 
to investigate why is 'disp' there and if it is a bug that it's not used 
(http://sourceware.org/ml/gdb-patches/2013-01/msg00767.html) , so I 
won't apply this patch, but will proceed with the other two.

Thanks for reviewing,

Aleksandar


  reply	other threads:[~2013-04-01 12:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31  3:24 Aleksandar Ristovski
2013-01-31 16:10 ` Tom Tromey
2013-01-31 16:12   ` Aleksandar Ristovski
2013-01-31 18:20     ` Tom Tromey
2013-01-31 18:29       ` Aleksandar Ristovski
2013-03-29  5:54 ` Joel Brobecker
2013-04-01 12:29   ` Aleksandar Ristovski [this message]
2013-04-01 12:26     ` Aleksandar Ristovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51597CC0.6030408@qnx.com \
    --to=aristovski@qnx.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox