From: Tom Tromey <tromey@redhat.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] cleanup: Wunused - amd64
Date: Thu, 31 Jan 2013 16:10:00 -0000 [thread overview]
Message-ID: <871ud19vvy.fsf@fleche.redhat.com> (raw)
In-Reply-To: <5109E3D3.90207@qnx.com> (Aleksandar Ristovski's message of "Wed, 30 Jan 2013 22:24:03 -0500")
>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:
Aleksandar> * amd64-tdep.c (fixup_riprel): Remove unused
Aleksandar> BYTE_ORDER, DISP.
This one isn't obvious to me.
Aleksandar> /* Compute the rip-relative address. */
Aleksandar> - disp = extract_signed_integer (insn, sizeof (int32_t), byte_order);
Is it really the case that this code does not need to use 'disp'?
Or is it a bug that it doesn't use it?
Tom
next prev parent reply other threads:[~2013-01-31 16:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 3:24 Aleksandar Ristovski
2013-01-31 16:10 ` Tom Tromey [this message]
2013-01-31 16:12 ` Aleksandar Ristovski
2013-01-31 18:20 ` Tom Tromey
2013-01-31 18:29 ` Aleksandar Ristovski
2013-03-29 5:54 ` Joel Brobecker
2013-04-01 12:29 ` Aleksandar Ristovski
2013-04-01 12:26 ` Aleksandar Ristovski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ud19vvy.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=aristovski@qnx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox