Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aleksandar Ristovski <aristovski@qnx.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [patch] cleanup: Wunused - amd64
Date: Thu, 31 Jan 2013 03:24:00 -0000	[thread overview]
Message-ID: <5109E3D3.90207@qnx.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 261 bytes --]

Hello,

This is removing unused variables and allows compiling with -Wunused.

Thanks,

Aleksandar Ristovski
QNX Software Systems


ChangeLog:

   Aleksandar Ristovski  <aristovski@qnx.com>

      * amd64-tdep.c (fixup_riprel): Remove unused BYTE_ORDER, DISP.


[-- Attachment #2: Wunused-amd64-201301302100.patch --]
[-- Type: text/x-patch, Size: 1142 bytes --]

Index: gdb/amd64-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/amd64-tdep.c,v
retrieving revision 1.117
diff -u -p -r1.117 amd64-tdep.c
--- gdb/amd64-tdep.c	1 Jan 2013 06:32:37 -0000	1.117
+++ gdb/amd64-tdep.c	30 Jan 2013 22:25:14 -0000
@@ -1225,12 +1225,10 @@ static void
 fixup_riprel (struct gdbarch *gdbarch, struct displaced_step_closure *dsc,
 	      CORE_ADDR from, CORE_ADDR to, struct regcache *regs)
 {
-  enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
   const struct amd64_insn *insn_details = &dsc->insn_details;
   int modrm_offset = insn_details->modrm_offset;
   gdb_byte *insn = insn_details->raw_insn + modrm_offset;
   CORE_ADDR rip_base;
-  int32_t disp;
   int insn_length;
   int arch_tmp_regno, tmp_regno;
   ULONGEST orig_value;
@@ -1239,7 +1237,6 @@ fixup_riprel (struct gdbarch *gdbarch, s
   ++insn;
 
   /* Compute the rip-relative address.	*/
-  disp = extract_signed_integer (insn, sizeof (int32_t), byte_order);
   insn_length = gdb_buffered_insn_length (gdbarch, dsc->insn_buf,
 					  dsc->max_len, from);
   rip_base = from + insn_length;


             reply	other threads:[~2013-01-31  3:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-31  3:24 Aleksandar Ristovski [this message]
2013-01-31 16:10 ` Tom Tromey
2013-01-31 16:12   ` Aleksandar Ristovski
2013-01-31 18:20     ` Tom Tromey
2013-01-31 18:29       ` Aleksandar Ristovski
2013-03-29  5:54 ` Joel Brobecker
2013-04-01 12:29   ` Aleksandar Ristovski
2013-04-01 12:26     ` Aleksandar Ristovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5109E3D3.90207@qnx.com \
    --to=aristovski@qnx.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox