From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-98121-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16341 invoked by alias); 31 Jan 2013 16:10:03 -0000
Received: (qmail 16296 invoked by uid 22791); 31 Jan 2013 16:10:01 -0000
X-SWARE-Spam-Status: No, hits=-6.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 31 Jan 2013 16:09:57 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0VG9t5J008848	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 31 Jan 2013 11:09:55 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0VG9rTO006941	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Thu, 31 Jan 2013 11:09:54 -0500
From: Tom Tromey <tromey@redhat.com>
To: Aleksandar Ristovski <aristovski@qnx.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] cleanup: Wunused - amd64
References: <5109E3D3.90207@qnx.com>
Date: Thu, 31 Jan 2013 16:10:00 -0000
In-Reply-To: <5109E3D3.90207@qnx.com> (Aleksandar Ristovski's message of "Wed,	30 Jan 2013 22:24:03 -0500")
Message-ID: <871ud19vvy.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2013-01/txt/msg00751.txt.bz2

>>>>> "Aleksandar" == Aleksandar Ristovski <aristovski@qnx.com> writes:

Aleksandar>      * amd64-tdep.c (fixup_riprel): Remove unused
Aleksandar>      BYTE_ORDER, DISP.

This one isn't obvious to me.

Aleksandar>    /* Compute the rip-relative address.	*/
Aleksandar> -  disp = extract_signed_integer (insn, sizeof (int32_t), byte_order);

Is it really the case that this code does not need to use 'disp'?
Or is it a bug that it doesn't use it?

Tom