From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12896 invoked by alias); 1 Apr 2013 12:26:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12811 invoked by uid 89); 1 Apr 2013 12:25:49 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from na3sys009aog132.obsmtp.com (HELO na3sys009aog132.obsmtp.com) (74.125.149.250) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Apr 2013 12:25:43 +0000 Received: from mx10.qnx.com ([209.226.137.110]) (using TLSv1) by na3sys009aob132.postini.com ([74.125.148.12]) with SMTP ID DSNKUVl8wp/KbdeCTyIX8AQ4hRx9rWxiwjzn@postini.com; Mon, 01 Apr 2013 05:25:43 PDT Received: by mx10.qnx.com (Postfix, from userid 500) id 0846720E4E; Mon, 1 Apr 2013 08:25:38 -0400 (EDT) Received: from exhts.ott.qnx.com (exch1 [10.222.2.137]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mx10.qnx.com (Postfix) with ESMTPS id 72C9F20A49; Mon, 1 Apr 2013 08:25:37 -0400 (EDT) Received: from [10.222.96.215] (10.222.2.5) by EXCH1.ott.qnx.com (10.222.2.137) with Microsoft SMTP Server id 14.2.318.4; Mon, 1 Apr 2013 08:25:37 -0400 Message-ID: <51597CC0.6030408@qnx.com> Date: Mon, 01 Apr 2013 12:29:00 -0000 From: Aleksandar Ristovski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 Newsgroups: gmane.comp.gdb.patches To: Joel Brobecker CC: "gdb-patches@sourceware.org" Subject: Re: [patch] cleanup: Wunused - amd64 References: <5109E3D3.90207@qnx.com> <20130329002606.GG4758@adacore.com> In-Reply-To: <20130329002606.GG4758@adacore.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-04/txt/msg00005.txt.bz2 On 13-03-28 08:26 PM, Joel Brobecker wrote: >> Aleksandar Ristovski >> >> * amd64-tdep.c (fixup_riprel): Remove unused BYTE_ORDER, DISP. > > Was this ever reviewed? If not, I apologize. Approved. > Tom has expressed concerns about removing 'disp', and I haven't had time to investigate why is 'disp' there and if it is a bug that it's not used (http://sourceware.org/ml/gdb-patches/2013-01/msg00767.html) , so I won't apply this patch, but will proceed with the other two. Thanks for reviewing, Aleksandar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12883 invoked by alias); 1 Apr 2013 12:26:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12837 invoked by uid 89); 1 Apr 2013 12:25:54 -0000 X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,FSL_HELO_BARE_IP_2,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_NUMERIC_HELO,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from plane.gmane.org (HELO plane.gmane.org) (80.91.229.3) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 01 Apr 2013 12:25:53 +0000 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UMdoU-0007yL-N5 for gdb-patches@sourceware.org; Mon, 01 Apr 2013 14:26:14 +0200 Received: from 209.226.137.106 ([209.226.137.106]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 01 Apr 2013 14:26:14 +0200 Received: from aristovski by 209.226.137.106 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 01 Apr 2013 14:26:14 +0200 To: gdb-patches@sourceware.org From: Aleksandar Ristovski Subject: Re: [patch] cleanup: Wunused - amd64 Date: Mon, 01 Apr 2013 12:26:00 -0000 Message-ID: <51597CC0.6030408@qnx.com> References: <5109E3D3.90207@qnx.com> <20130329002606.GG4758@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "gdb-patches@sourceware.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 In-Reply-To: <20130329002606.GG4758@adacore.com> X-SW-Source: 2013-04/txt/msg00004.txt.bz2 Message-ID: <20130401122600.DHY5foRYOG176-UbdW2JqgQiwR9pdEfTM8p6OV4PLkk@z> On 13-03-28 08:26 PM, Joel Brobecker wrote: >> Aleksandar Ristovski >> >> * amd64-tdep.c (fixup_riprel): Remove unused BYTE_ORDER, DISP. > > Was this ever reviewed? If not, I apologize. Approved. > Tom has expressed concerns about removing 'disp', and I haven't had time to investigate why is 'disp' there and if it is a bug that it's not used (http://sourceware.org/ml/gdb-patches/2013-01/msg00767.html) , so I won't apply this patch, but will proceed with the other two. Thanks for reviewing, Aleksandar