From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: markus.t.metzger@intel.com
Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com
Subject: Re: [rfc 2/8] record-full.c: rename record_ in record_full_.
Date: Fri, 15 Feb 2013 08:45:00 -0000 [thread overview]
Message-ID: <20130215084521.GA24792@host2.jankratochvil.net> (raw)
In-Reply-To: <1360859352-30399-3-git-send-email-markus.t.metzger@intel.com>
On Thu, 14 Feb 2013 17:29:06 +0100, markus.t.metzger@intel.com wrote:
> The changelog for this renaming will be huge. Is there a way to abbreviate or
> auto-generate it?
There is a script by Daniel Jacobowitz:
http://sourceware.org/ml/gdb-patches/2006-10/msg00085.html
But as you may find out it does not work too well.
I have tried right now some tiny fixes to it which I consider for many years
already but I apparently do not have experience with this change yet:
--- bin/fsfchangelog-orig 2013-02-15 09:42:14.836287199 +0100
+++ bin/fsfchangelog 2013-02-15 09:42:17.706281390 +0100
@@ -61,9 +61,9 @@ while (<DFILE>) {
# The first two patterns work with context diff files (diff -c). The
# third pattern works with unified diff files (diff -u).
- my $linestart = "[-a-zA-Z0-9_.]+";
+ my $linestart = "[-a-zA-Z0-9_.]+(?: [-a-zA-Z0-9_.]+)*";
if (/^\*\*\*\*\*\** ($linestart)/
- || /^[\-\+\!] ($linestart)[ \t]*\(.*/
+ || /^[\-\+\!] ?($linestart)[ \t]*\(.*/
|| /^@@ .* @@ ($linestart)/)
{
$fn = $1;
Although IMO automating it too much is not good as the goal is to
unconditionally self-review the patch, not to write the ChangeLog entry.
Thanks,
Jan
next prev parent reply other threads:[~2013-02-15 8:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 16:31 [rfc 0/8] refactor record markus.t.metzger
2013-02-14 16:30 ` [rfc 7/8] record: add "record backtrace" command markus.t.metzger
2013-02-14 16:30 ` [rfc 6/8] record disas: omit function names by default markus.t.metzger
2013-02-15 16:11 ` Jan Kratochvil
2013-02-15 18:21 ` Eli Zaretskii
2013-02-15 18:33 ` Jan Kratochvil
2013-02-15 19:05 ` Eli Zaretskii
2013-02-15 19:10 ` Jan Kratochvil
2013-02-18 9:43 ` Metzger, Markus T
2013-02-18 13:03 ` Jan Kratochvil
2013-02-18 13:30 ` Metzger, Markus T
2013-02-18 14:13 ` Jan Kratochvil
2013-02-18 14:51 ` Metzger, Markus T
2013-02-18 15:54 ` Jan Kratochvil
2013-02-19 8:34 ` Metzger, Markus T
2013-02-19 8:52 ` [RFC on command names] " Jan Kratochvil
2013-02-18 16:17 ` Eli Zaretskii
2013-02-15 20:43 ` Tom Tromey
2013-02-14 16:30 ` [rfc 8/8] record: add "record list" command markus.t.metzger
2013-02-14 16:30 ` [rfc 5/8] record: add "record disassemble" command markus.t.metzger
2013-02-14 16:30 ` [rfc 4/8] record: default target methods markus.t.metzger
2013-02-14 16:31 ` [rfc 2/8] record-full.c: rename record_ in record_full_ markus.t.metzger
2013-02-15 8:45 ` Jan Kratochvil [this message]
2013-02-14 16:31 ` [rfc 3/8] record-full.h: rename record_ into record_full_ markus.t.metzger
2013-02-14 16:32 ` [rfc 1/8] record: make it build again markus.t.metzger
2013-02-15 11:18 ` [rfc 0/8] refactor record Metzger, Markus T
2013-02-15 16:15 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215084521.GA24792@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox