Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
	       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	       "markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>
Subject: Re: [rfc 6/8] record disas: omit function names by default
Date: Mon, 18 Feb 2013 13:03:00 -0000	[thread overview]
Message-ID: <20130218130247.GA7250@host2.jankratochvil.net> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B2307B8072B@IRSMSX102.ger.corp.intel.com>

On Mon, 18 Feb 2013 10:42:44 +0100, Metzger, Markus T wrote:
> I don't insist on the names I gave those commands, but I'd rather we had a single
> word for each command. 

Due to <tab> completion and GDB abbreviations I do not think a single word is
required, as discussed occasionally in other cases on gdb-patches.


> Consider the existing "list" and "backtrace" commands. With the same arguments,
> they should be renamed into "list-source-lines" and "list-call-frames";-)

I see the problem in that these names already have some established meaning
now while you overload these names for a different functionality in btrace.


> Jan described it nicely above: "it's a 'backtrace' into history, not into upper frames".
> The term 'backtrace' suggests it's backwards and about functions. Being a "record"
> sub-command suggests it's working on the execution log.

I got used to it now but for new users it is not obvious enough.

"backtrace" is very fundamental commands of GDB with well known semantics.

Is that "record trace-functions" OK for you?


> The "btrace list" command that Jan mentioned works on blocks, i.e. sequentially
> executed code between two branches. This would be between "record list" and
> "record backtrace". I have not added a similar command to "record".

Is this the intended final state or do you still plan updating
archer-mmetzger-btrace?  I would find the "btrace ..." commands more suitable
to be placed under "record btrace ...", so that one has all the available
"record btrace ..." commands at one place with "record btrace <tab><tab>".

There can be "btrace ..." ones as aliases to them (although I do not think it
is needed, user can create an alias using the 'alias' command easily if
needed).


Thanks,
Jan


  reply	other threads:[~2013-02-18 13:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 16:31 [rfc 0/8] refactor record markus.t.metzger
2013-02-14 16:30 ` [rfc 4/8] record: default target methods markus.t.metzger
2013-02-14 16:30 ` [rfc 5/8] record: add "record disassemble" command markus.t.metzger
2013-02-14 16:30 ` [rfc 8/8] record: add "record list" command markus.t.metzger
2013-02-14 16:30 ` [rfc 7/8] record: add "record backtrace" command markus.t.metzger
2013-02-14 16:30 ` [rfc 6/8] record disas: omit function names by default markus.t.metzger
2013-02-15 16:11   ` Jan Kratochvil
2013-02-15 18:21     ` Eli Zaretskii
2013-02-15 18:33       ` Jan Kratochvil
2013-02-15 19:05         ` Eli Zaretskii
2013-02-15 19:10           ` Jan Kratochvil
2013-02-18  9:43             ` Metzger, Markus T
2013-02-18 13:03               ` Jan Kratochvil [this message]
2013-02-18 13:30                 ` Metzger, Markus T
2013-02-18 14:13                   ` Jan Kratochvil
2013-02-18 14:51                     ` Metzger, Markus T
2013-02-18 15:54                       ` Jan Kratochvil
2013-02-19  8:34                         ` Metzger, Markus T
2013-02-19  8:52                           ` [RFC on command names] " Jan Kratochvil
2013-02-18 16:17               ` Eli Zaretskii
2013-02-15 20:43         ` Tom Tromey
2013-02-14 16:31 ` [rfc 2/8] record-full.c: rename record_ in record_full_ markus.t.metzger
2013-02-15  8:45   ` Jan Kratochvil
2013-02-14 16:31 ` [rfc 3/8] record-full.h: rename record_ into record_full_ markus.t.metzger
2013-02-14 16:32 ` [rfc 1/8] record: make it build again markus.t.metzger
2013-02-15 11:18 ` [rfc 0/8] refactor record Metzger, Markus T
2013-02-15 16:15 ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130218130247.GA7250@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@gmail.com \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox