Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: markus.t.metzger@intel.com
Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com
Subject: Re: [rfc 6/8] record disas: omit function names by default
Date: Fri, 15 Feb 2013 16:11:00 -0000	[thread overview]
Message-ID: <20130215161049.GA6219@host2.jankratochvil.net> (raw)
In-Reply-To: <1360859352-30399-7-git-send-email-markus.t.metzger@intel.com>

On Thu, 14 Feb 2013 17:29:10 +0100, markus.t.metzger@intel.com wrote:
> Omit function names in the disassembly of the "record disassemble" command
> unless the "/f" modifier is specified.
> 
> This helps align the disassembly output across functions.  The branch
> destination is already obvious from the instruction order.

FYI from the user point of view I find the output more readable with /f.
But I do not have practical experience with it, I am fine with it as you wrote
it if you think so.


Just now when playing with the branch the commands record disassemble vs. list
vs. backtrace should have some better short description in the help text.
Particularly record backtrace I had some difficult to understand first.

record disassemble:
Print disassembled instructions as stored in the execution log.

record backtrace:
Print function names from which instruction in the execution log ran.

recost list:
<it is currently not implemented in archer-mmetzger-btrace and I did not dig
out the former patches>


This is just a suggestion, maybe Eli could also suggest some better
formulation.


Thanks,
Jan


  reply	other threads:[~2013-02-15 16:11 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-14 16:31 [rfc 0/8] refactor record markus.t.metzger
2013-02-14 16:30 ` [rfc 4/8] record: default target methods markus.t.metzger
2013-02-14 16:30 ` [rfc 5/8] record: add "record disassemble" command markus.t.metzger
2013-02-14 16:30 ` [rfc 8/8] record: add "record list" command markus.t.metzger
2013-02-14 16:30 ` [rfc 7/8] record: add "record backtrace" command markus.t.metzger
2013-02-14 16:30 ` [rfc 6/8] record disas: omit function names by default markus.t.metzger
2013-02-15 16:11   ` Jan Kratochvil [this message]
2013-02-15 18:21     ` Eli Zaretskii
2013-02-15 18:33       ` Jan Kratochvil
2013-02-15 19:05         ` Eli Zaretskii
2013-02-15 19:10           ` Jan Kratochvil
2013-02-18  9:43             ` Metzger, Markus T
2013-02-18 13:03               ` Jan Kratochvil
2013-02-18 13:30                 ` Metzger, Markus T
2013-02-18 14:13                   ` Jan Kratochvil
2013-02-18 14:51                     ` Metzger, Markus T
2013-02-18 15:54                       ` Jan Kratochvil
2013-02-19  8:34                         ` Metzger, Markus T
2013-02-19  8:52                           ` [RFC on command names] " Jan Kratochvil
2013-02-18 16:17               ` Eli Zaretskii
2013-02-15 20:43         ` Tom Tromey
2013-02-14 16:31 ` [rfc 3/8] record-full.h: rename record_ into record_full_ markus.t.metzger
2013-02-14 16:31 ` [rfc 2/8] record-full.c: rename record_ in record_full_ markus.t.metzger
2013-02-15  8:45   ` Jan Kratochvil
2013-02-14 16:32 ` [rfc 1/8] record: make it build again markus.t.metzger
2013-02-15 11:18 ` [rfc 0/8] refactor record Metzger, Markus T
2013-02-15 16:15 ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130215161049.GA6219@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@gmail.com \
    --cc=markus.t.metzger@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox