From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3850 invoked by alias); 15 Feb 2013 16:11:07 -0000 Received: (qmail 3841 invoked by uid 22791); 15 Feb 2013 16:11:06 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Feb 2013 16:10:56 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1FGAr11026366 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Feb 2013 11:10:53 -0500 Received: from host2.jankratochvil.net (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1FGAnUd002868 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 15 Feb 2013 11:10:52 -0500 Date: Fri, 15 Feb 2013 16:11:00 -0000 From: Jan Kratochvil To: markus.t.metzger@intel.com Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com Subject: Re: [rfc 6/8] record disas: omit function names by default Message-ID: <20130215161049.GA6219@host2.jankratochvil.net> References: <1360859352-30399-1-git-send-email-markus.t.metzger@intel.com> <1360859352-30399-7-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1360859352-30399-7-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00392.txt.bz2 On Thu, 14 Feb 2013 17:29:10 +0100, markus.t.metzger@intel.com wrote: > Omit function names in the disassembly of the "record disassemble" command > unless the "/f" modifier is specified. > > This helps align the disassembly output across functions. The branch > destination is already obvious from the instruction order. FYI from the user point of view I find the output more readable with /f. But I do not have practical experience with it, I am fine with it as you wrote it if you think so. Just now when playing with the branch the commands record disassemble vs. list vs. backtrace should have some better short description in the help text. Particularly record backtrace I had some difficult to understand first. record disassemble: Print disassembled instructions as stored in the execution log. record backtrace: Print function names from which instruction in the execution log ran. recost list: This is just a suggestion, maybe Eli could also suggest some better formulation. Thanks, Jan