Re: [rfc 6/8] record disas: omit function names by default

Jan Kratochvil
2013-02-18T14:13:29Z

On Mon, 18 Feb 2013 14:29:48 +0100, Metzger, Markus T wrote:
> How long did it take you?

Longer than a newbie give up on trying to understand it. :-)

> "record trace-functions" sounds like it would enable tracing functions.

I agree.

> If it has to be some two-word combination, I'd rather go with "record list-", i.e.
> "record list-functions", "record list-lines", and, for the sake of consistency,
> "record list-instructions".

Yes. In fact "record disassemble" (or "btrace disassemble") also do not seem
so obvious to me.

> Or are you OK with "record disassemble" and "record list" and just objecting
> to "record backtrace"?

I primarily object "record backtrace", but those two are also not obvious IMO.

> I intend to remove the "btrace" command and all its sub-commands. I just kept them
> so people can compare them with the new "record" commands.
>
> Regarding "brace list" I do not plan to add a corresponding "record" command.

What should do the current "record list" hook other than what "btrace list" did?

Current to_list_record and to_list_record_range are always left NULL in
archer-mmetzger-btrace so there isn't what to compare yet:)
(gdb) record list
You can't do that when your target is `record-btrace'

Thanks,
Jan