From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10253 invoked by alias); 15 Feb 2013 08:45:41 -0000 Received: (qmail 10242 invoked by uid 22791); 15 Feb 2013 08:45:40 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Feb 2013 08:45:28 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r1F8jQXW010207 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 15 Feb 2013 03:45:26 -0500 Received: from host2.jankratochvil.net (ovpn-116-18.ams2.redhat.com [10.36.116.18]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r1F8jMXo010240 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 15 Feb 2013 03:45:25 -0500 Date: Fri, 15 Feb 2013 08:45:00 -0000 From: Jan Kratochvil To: markus.t.metzger@intel.com Cc: gdb-patches@sourceware.org, markus.t.metzger@gmail.com Subject: Re: [rfc 2/8] record-full.c: rename record_ in record_full_. Message-ID: <20130215084521.GA24792@host2.jankratochvil.net> References: <1360859352-30399-1-git-send-email-markus.t.metzger@intel.com> <1360859352-30399-3-git-send-email-markus.t.metzger@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1360859352-30399-3-git-send-email-markus.t.metzger@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00385.txt.bz2 On Thu, 14 Feb 2013 17:29:06 +0100, markus.t.metzger@intel.com wrote: > The changelog for this renaming will be huge. Is there a way to abbreviate or > auto-generate it? There is a script by Daniel Jacobowitz: http://sourceware.org/ml/gdb-patches/2006-10/msg00085.html But as you may find out it does not work too well. I have tried right now some tiny fixes to it which I consider for many years already but I apparently do not have experience with this change yet: --- bin/fsfchangelog-orig 2013-02-15 09:42:14.836287199 +0100 +++ bin/fsfchangelog 2013-02-15 09:42:17.706281390 +0100 @@ -61,9 +61,9 @@ while () { # The first two patterns work with context diff files (diff -c). The # third pattern works with unified diff files (diff -u). - my $linestart = "[-a-zA-Z0-9_.]+"; + my $linestart = "[-a-zA-Z0-9_.]+(?: [-a-zA-Z0-9_.]+)*"; if (/^\*\*\*\*\*\** ($linestart)/ - || /^[\-\+\!] ($linestart)[ \t]*\(.*/ + || /^[\-\+\!] ?($linestart)[ \t]*\(.*/ || /^@@ .* @@ ($linestart)/) { $fn = $1; Although IMO automating it too much is not good as the goal is to unconditionally self-review the patch, not to write the ChangeLog entry. Thanks, Jan