From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Tom Tromey <tromey@redhat.com>,
Joel Brobecker <brobecker@adacore.com>,
gdb-patches@sourceware.org
Subject: [obv] Fix new FAIL on 64-bit targets [Re: [PATCH 1/3] Test of breakpoint output for dprintf]
Date: Fri, 11 Jan 2013 15:22:00 -0000 [thread overview]
Message-ID: <20130111152151.GA15138@host2.jankratochvil.net> (raw)
In-Reply-To: <50EED5CD.9020802@codesourcery.com>
On Thu, 10 Jan 2013 15:53:01 +0100, Yao Qi wrote:
> * gdb.base/dprintf.exp: Check the output of 'info breakpoints'
> for dprintf.
> * gdb.mi/mi-breakpoint-changed.exp (test_insert_delete_modify):
> Check the fields in "=breakpoint-created" for dprintf.
It has FAIL on 64-bit targets:
gdb_expect_list pattern: /[^M
]Num Type Disp Enb Address What/
info breakpoints^M
Num Type Disp Enb Address What^M
2 breakpoint keep y 0x0000000000400743 in main at ./gdb.base/dprintf.c:33^M
[...]
(gdb) FAIL: gdb.base/dprintf.exp: dprintf info 1 (pattern 1)
Checked in as obvious.
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2013-01/msg00059.html
--- src/gdb/testsuite/ChangeLog 2013/01/11 00:31:56 1.3500
+++ src/gdb/testsuite/ChangeLog 2013/01/11 15:21:13 1.3501
@@ -1,3 +1,8 @@
+2013-01-11 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.base/dprintf.exp (dprintf info 1): Fix expectation on 64-bit
+ targets.
+
2013-01-11 Yao Qi <yao@codesourcery.com>
* gdb.base/dprintf.exp: Check the output of 'info breakpoints'
--- src/gdb/testsuite/gdb.base/dprintf.exp 2013/01/11 00:31:58 1.7
+++ src/gdb/testsuite/gdb.base/dprintf.exp 2013/01/11 15:21:14 1.8
@@ -44,7 +44,7 @@
"Dprintf .*"
gdb_test_sequence "info breakpoints" "dprintf info 1" {
- "\[\r\n\]Num Type Disp Enb Address What"
+ "\[\r\n\]Num Type Disp Enb Address +What"
"\[\r\n\]2 breakpoint"
"\[\r\n\]3 dprintf"
"\[\r\n\] printf \"At foo entry\\\\n\""
next prev parent reply other threads:[~2013-01-11 15:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 4:13 [PATCH 0/3] dprintf tweaks Yao Qi
2012-12-12 4:13 ` [PATCH 1/3] Test of breakpoint output for dprintf Yao Qi
2013-01-09 20:35 ` Tom Tromey
2013-01-10 5:43 ` Joel Brobecker
2013-01-10 14:53 ` Yao Qi
2013-01-10 14:55 ` Tom Tromey
2013-01-11 15:22 ` Jan Kratochvil [this message]
2012-12-12 4:13 ` [PATCH 3/3] Assert 'printf_line' is non-null Yao Qi
2013-01-09 21:43 ` Tom Tromey
2012-12-12 4:13 ` [PATCH 2/3] Remove dead code for dprintf Yao Qi
2013-01-09 20:45 ` Tom Tromey
2013-01-07 14:16 ` [ping]: [PATCH 0/3] dprintf tweaks Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130111152151.GA15138@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox