From: Yao Qi <yao@codesourcery.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH 2/3] Remove dead code for dprintf.
Date: Wed, 12 Dec 2012 04:13:00 -0000 [thread overview]
Message-ID: <1355285581-28889-3-git-send-email-yao@codesourcery.com> (raw)
In-Reply-To: <1355285581-28889-1-git-send-email-yao@codesourcery.com>
Hi,
For a given dprintf B, B->commands can never be null, so the condition
below is always false. This patch is to remove it as sort of dead
code.
When creating a dprintf B, the following call chain can be found
unconditionally,
init_breakpoint_sal
--> update_dprintf_command_list (because B->extra_string can't be null)
--> breakpoint_set_commands (because PRINT_LINE can't be null)
--> set B->commands.
gdb:
2012-12-12 Yao Qi <yao@codesourcery.com>
* breakpoint.c (print_one_breakpoint_location): Remove dead code.
---
gdb/breakpoint.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index e1da50b..65bdc2c 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -6091,15 +6091,6 @@ print_one_breakpoint_location (struct breakpoint *b,
ui_out_text (uiout, " bytes\n");
}
}
-
- if (!part_of_multiple && b->extra_string
- && b->type == bp_dprintf && !b->commands)
- {
- annotate_field (7);
- ui_out_text (uiout, "\t(agent printf) ");
- ui_out_field_string (uiout, "printf", b->extra_string);
- ui_out_text (uiout, "\n");
- }
l = b->commands ? b->commands->commands : NULL;
if (!part_of_multiple && l)
--
1.7.7.6
next prev parent reply other threads:[~2012-12-12 4:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 4:13 [PATCH 0/3] dprintf tweaks Yao Qi
2012-12-12 4:13 ` [PATCH 3/3] Assert 'printf_line' is non-null Yao Qi
2013-01-09 21:43 ` Tom Tromey
2012-12-12 4:13 ` Yao Qi [this message]
2013-01-09 20:45 ` [PATCH 2/3] Remove dead code for dprintf Tom Tromey
2012-12-12 4:13 ` [PATCH 1/3] Test of breakpoint output " Yao Qi
2013-01-09 20:35 ` Tom Tromey
2013-01-10 5:43 ` Joel Brobecker
2013-01-10 14:53 ` Yao Qi
2013-01-10 14:55 ` Tom Tromey
2013-01-11 15:22 ` [obv] Fix new FAIL on 64-bit targets [Re: [PATCH 1/3] Test of breakpoint output for dprintf] Jan Kratochvil
2013-01-07 14:16 ` [ping]: [PATCH 0/3] dprintf tweaks Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355285581-28889-3-git-send-email-yao@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox