From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: Joel Brobecker <brobecker@adacore.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/3] Test of breakpoint output for dprintf
Date: Thu, 10 Jan 2013 14:55:00 -0000 [thread overview]
Message-ID: <871udtw0j2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <50EED5CD.9020802@codesourcery.com> (Yao Qi's message of "Thu, 10 Jan 2013 22:53:01 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
Yao> I agree, and that is why I break pattern into several lines. I use
Yao> gdb_test_sequence in the new version of patch, which looks better.
Nice, I didn't know about this proc.
I like the result.
Yao> How about the new version?
Thank you for doing this.
The patch is ok.
Tom
next prev parent reply other threads:[~2013-01-10 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 4:13 [PATCH 0/3] dprintf tweaks Yao Qi
2012-12-12 4:13 ` [PATCH 1/3] Test of breakpoint output for dprintf Yao Qi
2013-01-09 20:35 ` Tom Tromey
2013-01-10 5:43 ` Joel Brobecker
2013-01-10 14:53 ` Yao Qi
2013-01-10 14:55 ` Tom Tromey [this message]
2013-01-11 15:22 ` [obv] Fix new FAIL on 64-bit targets [Re: [PATCH 1/3] Test of breakpoint output for dprintf] Jan Kratochvil
2012-12-12 4:13 ` [PATCH 2/3] Remove dead code for dprintf Yao Qi
2013-01-09 20:45 ` Tom Tromey
2012-12-12 4:13 ` [PATCH 3/3] Assert 'printf_line' is non-null Yao Qi
2013-01-09 21:43 ` Tom Tromey
2013-01-07 14:16 ` [ping]: [PATCH 0/3] dprintf tweaks Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871udtw0j2.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox