From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Test of breakpoint output for dprintf
Date: Thu, 10 Jan 2013 05:43:00 -0000 [thread overview]
Message-ID: <20130110054342.GI6143@adacore.com> (raw)
In-Reply-To: <87vcb6w0v7.fsf@fleche.redhat.com>
> Yao> +gdb_test "info breakpoints" "3\[\t \]+dprintf .*
> Yao> +\[\t \]+printf \"At foo entry\\\\n\".
> Yao> +\[\t \]+continue.
> Yao> +4\[\t \]+dprintf .*
> Yao> +\[\t \]+printf \"arg=%d, g=%d\\\\n\", arg, g.
> Yao> +\[\t \]+continue." "dprintf info 1"
>
> I find this style of test pretty hard to read.
> How about using "\n" instead of a newline?
> Or writing the string some other way to make it more readable?
FWIW, I sometimes do the following when writing tests:
gdb_test "info tasks" \
[join {" +ID +TID P-ID Pri State +Name" \
" +1 .* main_task" \
" +2 .* task_list\\(1\\)" \
"\\* +3 .* task_list\\(2\\)" \
" +4 .* task_list\\(3\\)"} \
"\r\n"] \
"info tasks after hitting breakpoint"
I find that having a multi-line expected output shown as multiple
lines is easier to understand than one ginormous string...
--
Joel
next prev parent reply other threads:[~2013-01-10 5:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-12 4:13 [PATCH 0/3] dprintf tweaks Yao Qi
2012-12-12 4:13 ` [PATCH 1/3] Test of breakpoint output for dprintf Yao Qi
2013-01-09 20:35 ` Tom Tromey
2013-01-10 5:43 ` Joel Brobecker [this message]
2013-01-10 14:53 ` Yao Qi
2013-01-10 14:55 ` Tom Tromey
2013-01-11 15:22 ` [obv] Fix new FAIL on 64-bit targets [Re: [PATCH 1/3] Test of breakpoint output for dprintf] Jan Kratochvil
2012-12-12 4:13 ` [PATCH 3/3] Assert 'printf_line' is non-null Yao Qi
2013-01-09 21:43 ` Tom Tromey
2012-12-12 4:13 ` [PATCH 2/3] Remove dead code for dprintf Yao Qi
2013-01-09 20:45 ` Tom Tromey
2013-01-07 14:16 ` [ping]: [PATCH 0/3] dprintf tweaks Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130110054342.GI6143@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox