[PATCH] Remove unnecessary '#' from an assembly test file

[PATCH] Remove unnecessary '#' from an assembly test file

[Yufeng Zhang]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi,

This patch removes a hash character from the end of a symbol in 
gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S

While some assemblers (e.g. x86 gas) are tolerant of it, others (e.g. 
arm gas) do complain about it.

Is it OK?

Thanks,
Yufeng


testsuite/ChangeLog

2012-10-10  Yufeng Zhang  <yufeng.zhang@arm.com>

	* gdb.dwarf2/dw2-icc-opaque.S: Remove '#'.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: hash-symbol.patch --]
[-- Type: text/x-patch; name=hash-symbol.patch, Size: 392 bytes --]

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
index 47b017b..ddeb6c8 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
@@ -35,7 +35,7 @@
 	.file "opaque-pointer.c"
 	.data
 	.comm p_struct,8,8
-	.global p_struct#
+	.global p_struct
 
 	.section .debug_info
 debug_info_seg1:

Re: [PATCH] Remove unnecessary '#' from an assembly test file

[Yao Qi]

On 10/10/2012 11:48 PM, Yufeng Zhang wrote:
> This patch removes a hash character from the end of a symbol in
> gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
>
> While some assemblers (e.g. x86 gas) are tolerant of it, others (e.g.
> arm gas) do complain about it.
>

IIUC, dw2-icc-opaque.S is generated by icc, and looks icc adds a 
trailing '#' at the end of symbol.  The '#' is useless here, AFAICS.

On the other hand, tic6x gas complains about it as well.  I vote to 
remove this '#' as well, but I am not the people to approve it.

-- 
Yao

Re: [PATCH] Remove unnecessary '#' from an assembly test file

[Joel Brobecker]

> 2012-10-10  Yufeng Zhang  <yufeng.zhang@arm.com>
> 
> 	* gdb.dwarf2/dw2-icc-opaque.S: Remove '#'.

Looks OK to me. Do you have write permissions on the GDB repository?

-- 
Joel

Re: [PATCH] Remove unnecessary '#' from an assembly test file

[Yufeng Zhang]

On 10/14/12 18:10, Joel Brobecker wrote:
>> 2012-10-10  Yufeng Zhang<yufeng.zhang@arm.com>
>>
>> 	* gdb.dwarf2/dw2-icc-opaque.S: Remove '#'.
>
> Looks OK to me. Do you have write permissions on the GDB repository?

No, I don't.  Can you help commit it please?

Thanks,
Yufeng

Re: [PATCH] Remove unnecessary '#' from an assembly test file

[Joel Brobecker]

> >>2012-10-10  Yufeng Zhang<yufeng.zhang@arm.com>
> >>
> >>	* gdb.dwarf2/dw2-icc-opaque.S: Remove '#'.
> >
> >Looks OK to me. Do you have write permissions on the GDB repository?
> 
> No, I don't.  Can you help commit it please?

Sure, now done.

-- 
Joel