From: Yao Qi <yao@codesourcery.com>
To: Yufeng Zhang <Yufeng.Zhang@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove unnecessary '#' from an assembly test file
Date: Fri, 12 Oct 2012 10:01:00 -0000 [thread overview]
Message-ID: <5077EA6D.8050208@codesourcery.com> (raw)
In-Reply-To: <507598B8.2070207@arm.com>
On 10/10/2012 11:48 PM, Yufeng Zhang wrote:
> This patch removes a hash character from the end of a symbol in
> gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
>
> While some assemblers (e.g. x86 gas) are tolerant of it, others (e.g.
> arm gas) do complain about it.
>
IIUC, dw2-icc-opaque.S is generated by icc, and looks icc adds a
trailing '#' at the end of symbol. The '#' is useless here, AFAICS.
On the other hand, tic6x gas complains about it as well. I vote to
remove this '#' as well, but I am not the people to approve it.
--
Yao
next prev parent reply other threads:[~2012-10-12 10:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-10 15:48 Yufeng Zhang
2012-10-12 10:01 ` Yao Qi [this message]
2012-10-14 17:10 ` Joel Brobecker
2012-10-15 8:56 ` Yufeng Zhang
2012-10-15 17:26 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5077EA6D.8050208@codesourcery.com \
--to=yao@codesourcery.com \
--cc=Yufeng.Zhang@arm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox