From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9184 invoked by alias); 12 Oct 2012 10:01:22 -0000 Received: (qmail 9167 invoked by uid 22791); 12 Oct 2012 10:01:19 -0000 X-SWARE-Spam-Status: No, hits=-4.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 12 Oct 2012 10:01:15 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1TMc3P-000188-DD from Yao_Qi@mentor.com ; Fri, 12 Oct 2012 03:01:15 -0700 Received: from SVR-ORW-FEM-05.mgc.mentorg.com ([147.34.97.43]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 12 Oct 2012 03:01:15 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.1.289.1; Fri, 12 Oct 2012 03:01:14 -0700 Message-ID: <5077EA6D.8050208@codesourcery.com> Date: Fri, 12 Oct 2012 10:01:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Yufeng Zhang CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Remove unnecessary '#' from an assembly test file References: <507598B8.2070207@arm.com> In-Reply-To: <507598B8.2070207@arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00196.txt.bz2 On 10/10/2012 11:48 PM, Yufeng Zhang wrote: > This patch removes a hash character from the end of a symbol in > gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S > > While some assemblers (e.g. x86 gas) are tolerant of it, others (e.g. > arm gas) do complain about it. > IIUC, dw2-icc-opaque.S is generated by icc, and looks icc adds a trailing '#' at the end of symbol. The '#' is useless here, AFAICS. On the other hand, tic6x gas complains about it as well. I vote to remove this '#' as well, but I am not the people to approve it. -- Yao