Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yufeng Zhang <Yufeng.Zhang@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH] Remove unnecessary '#' from an assembly test file
Date: Wed, 10 Oct 2012 15:48:00 -0000	[thread overview]
Message-ID: <507598B8.2070207@arm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

Hi,

This patch removes a hash character from the end of a symbol in 
gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S

While some assemblers (e.g. x86 gas) are tolerant of it, others (e.g. 
arm gas) do complain about it.

Is it OK?

Thanks,
Yufeng


testsuite/ChangeLog

2012-10-10  Yufeng Zhang  <yufeng.zhang@arm.com>

	* gdb.dwarf2/dw2-icc-opaque.S: Remove '#'.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: hash-symbol.patch --]
[-- Type: text/x-patch; name=hash-symbol.patch, Size: 392 bytes --]

diff --git a/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
index 47b017b..ddeb6c8 100644
--- a/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
+++ b/gdb/testsuite/gdb.dwarf2/dw2-icc-opaque.S
@@ -35,7 +35,7 @@
 	.file "opaque-pointer.c"
 	.data
 	.comm p_struct,8,8
-	.global p_struct#
+	.global p_struct
 
 	.section .debug_info
 debug_info_seg1:

             reply	other threads:[~2012-10-10 15:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-10 15:48 Yufeng Zhang [this message]
2012-10-12 10:01 ` Yao Qi
2012-10-14 17:10 ` Joel Brobecker
2012-10-15  8:56   ` Yufeng Zhang
2012-10-15 17:26     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507598B8.2070207@arm.com \
    --to=yufeng.zhang@arm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox