Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded
Date: Mon, 01 Oct 2012 05:21:00 -0000	[thread overview]
Message-ID: <20121001105048.5e05e4d7@spoyarek> (raw)
In-Reply-To: <20120930065211.GA21118@host2.jankratochvil.net>

On Sun, 30 Sep 2012 08:52:11 +0200, Jan wrote:
> Or gcc with -Wconversion:
> t.c: In function ‘main’:
> t.c:5:3: warning: conversion to ‘int’ from ‘long int’ may alter its
> value [-Wconversion] t.c:6:24: warning: conversion to ‘int’ from
> ‘long int’ may alter its value [-Wconversion]

This seems good.  However, how about committing these patches if
they're correct and then doing a run with -Wconversion?  The patches
are kinda unwieldy to maintain like this since it's quite painful
to review the entire thing repeatedly and edit changelogs, etc. Besides,
they should be safe for mainline since expansion of types should not
pose a regression risk. I volunteer to do this of course.

Regards,
Siddhesh


  reply	other threads:[~2012-10-01  5:21 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 13:33 Siddhesh Poyarekar
2012-09-28 11:20 ` Jan Kratochvil
2012-09-28 11:40   ` Siddhesh Poyarekar
2012-09-28 12:06     ` Jan Kratochvil
2012-09-28 12:19       ` Siddhesh Poyarekar
2012-09-29 17:39 ` Jan Kratochvil
2012-09-29 18:12   ` Jan Kratochvil
2012-09-30  6:52     ` Jan Kratochvil
2012-10-01  5:21       ` Siddhesh Poyarekar [this message]
2012-10-01  6:14         ` Jan Kratochvil
2012-10-03 13:12       ` Siddhesh Poyarekar
2012-10-03 18:38         ` Jan Kratochvil
2012-10-04  7:20           ` Siddhesh Poyarekar
2012-10-03 19:56         ` Jan Kratochvil
2012-10-04  7:13           ` Jan Kratochvil
2012-10-21  7:36             ` Siddhesh Poyarekar
2012-10-22 20:45               ` Tom Tromey
2012-10-23  1:34                 ` Jan Kratochvil
2012-10-23  1:58                   ` Jan Kratochvil
2012-10-23  2:29                     ` Siddhesh Poyarekar
2012-10-23  2:37                       ` Jan Kratochvil
2012-10-23  2:38                   ` Tom Tromey
2012-10-23 19:11               ` Jan Kratochvil
2012-10-24 18:33                 ` Tom Tromey
2012-10-24 18:55                   ` Jan Kratochvil
2012-10-24 20:18                     ` Tom Tromey
2012-10-25 15:54               ` Jan Kratochvil
2012-10-25 16:52                 ` Siddhesh Poyarekar
2012-11-06 20:01                   ` Jan Kratochvil
2012-11-07 13:48                     ` Jan Kratochvil
2012-11-13 19:46                       ` Tom Tromey
2012-11-13 19:55                         ` Jan Kratochvil
2012-11-01 15:24               ` Jan Kratochvil
2012-11-01 16:56                 ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121001105048.5e05e4d7@spoyarek \
    --to=siddhesh@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox