From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8050 invoked by alias); 1 Oct 2012 05:21:39 -0000 Received: (qmail 8042 invoked by uid 22791); 1 Oct 2012 05:21:37 -0000 X-SWARE-Spam-Status: No, hits=-8.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Oct 2012 05:21:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q915LV6P028901 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 1 Oct 2012 01:21:31 -0400 Received: from spoyarek (vpn1-7-99.ams2.redhat.com [10.36.7.99]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q915LSMb011399; Mon, 1 Oct 2012 01:21:29 -0400 Date: Mon, 01 Oct 2012 05:21:00 -0000 From: Siddhesh Poyarekar To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded Message-ID: <20121001105048.5e05e4d7@spoyarek> In-Reply-To: <20120930065211.GA21118@host2.jankratochvil.net> References: <20120927190053.1e7de264@spoyarek> <20120929173938.GA2987@host2.jankratochvil.net> <20120929181141.GA4009@host2.jankratochvil.net> <20120930065211.GA21118@host2.jankratochvil.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00000.txt.bz2 On Sun, 30 Sep 2012 08:52:11 +0200, Jan wrote: > Or gcc with -Wconversion: > t.c: In function ‘main’: > t.c:5:3: warning: conversion to ‘int’ from ‘long int’ may alter its > value [-Wconversion] t.c:6:24: warning: conversion to ‘int’ from > ‘long int’ may alter its value [-Wconversion] This seems good. However, how about committing these patches if they're correct and then doing a run with -Wconversion? The patches are kinda unwieldy to maintain like this since it's quite painful to review the entire thing repeatedly and edit changelogs, etc. Besides, they should be safe for mainline since expansion of types should not pose a regression risk. I volunteer to do this of course. Regards, Siddhesh