From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Siddhesh Poyarekar <siddhesh@redhat.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] bitpos expansion summary reloaded
Date: Tue, 23 Oct 2012 02:37:00 -0000 [thread overview]
Message-ID: <20121023023717.GA16314@host2.jankratochvil.net> (raw)
In-Reply-To: <20121023075834.130961dc@spoyarek>
On Tue, 23 Oct 2012 04:28:34 +0200, Siddhesh Poyarekar wrote:
> On Tue, 23 Oct 2012 03:58:35 +0200, Jan wrote:
> > The most easy would be to extend to 64-bit any automvaribles handling
> > TYPE_LENGTH (and some similar fields also being extended to 64-bit).
> > But this would include 64-bit lengths of scalar types which has been
> > considered as both performance wasteful and needless work to change
> > them all.
>
> Most of the warnings could be resolved by adding explicit casts
> wherever we know for sure that the value is safe to truncate.
This would be the case if we want to enable -Wconversion and also we want to
keep scalar types with 32-bit only variables.
While doable this is the most difficult variant to implement. One has to
properly verify all the callers/callees pass only scalar types and also never
forget to assert there only a scalar type has been passed - to prevent safety
regression with future changes.
Thanks,
Jan
next prev parent reply other threads:[~2012-10-23 2:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 13:33 Siddhesh Poyarekar
2012-09-28 11:20 ` Jan Kratochvil
2012-09-28 11:40 ` Siddhesh Poyarekar
2012-09-28 12:06 ` Jan Kratochvil
2012-09-28 12:19 ` Siddhesh Poyarekar
2012-09-29 17:39 ` Jan Kratochvil
2012-09-29 18:12 ` Jan Kratochvil
2012-09-30 6:52 ` Jan Kratochvil
2012-10-01 5:21 ` Siddhesh Poyarekar
2012-10-01 6:14 ` Jan Kratochvil
2012-10-03 13:12 ` Siddhesh Poyarekar
2012-10-03 18:38 ` Jan Kratochvil
2012-10-04 7:20 ` Siddhesh Poyarekar
2012-10-03 19:56 ` Jan Kratochvil
2012-10-04 7:13 ` Jan Kratochvil
2012-10-21 7:36 ` Siddhesh Poyarekar
2012-10-22 20:45 ` Tom Tromey
2012-10-23 1:34 ` Jan Kratochvil
2012-10-23 1:58 ` Jan Kratochvil
2012-10-23 2:29 ` Siddhesh Poyarekar
2012-10-23 2:37 ` Jan Kratochvil [this message]
2012-10-23 2:38 ` Tom Tromey
2012-10-23 19:11 ` Jan Kratochvil
2012-10-24 18:33 ` Tom Tromey
2012-10-24 18:55 ` Jan Kratochvil
2012-10-24 20:18 ` Tom Tromey
2012-10-25 15:54 ` Jan Kratochvil
2012-10-25 16:52 ` Siddhesh Poyarekar
2012-11-06 20:01 ` Jan Kratochvil
2012-11-07 13:48 ` Jan Kratochvil
2012-11-13 19:46 ` Tom Tromey
2012-11-13 19:55 ` Jan Kratochvil
2012-11-01 15:24 ` Jan Kratochvil
2012-11-01 16:56 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023023717.GA16314@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=siddhesh@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox