From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/4] bitpos expansion summary reloaded
Date: Thu, 27 Sep 2012 13:33:00 -0000 [thread overview]
Message-ID: <20120927190053.1e7de264@spoyarek> (raw)
Hi,
This is iteration (insert-large-number-here) of the bitpos expansion
patch with all its reviews, etc. The patch is now split into 4 parts
as follows:
1) The main bitpos and type.length expansion changes to generic code
2) Additional validation in some places to ensure that a size fits into
memory (ensure_size_t)
3) Changes to watchpoint functions
4) bitpos and type length related changes to tdep files. I separated
these out since they had a related pattern of change, i.e. pushing
of variables on stack and getting/storing return values.
The 4th part is new, but the content is not very different. Over time
I have also picked out portions of the patch and pushed them as
independent changes (some of which I rightly got flak for ;)) and as a
result I have been able to shave off a total of about 1k lines off the
patch, making it a bit easier to review. The split is also aimed at
easing the review.
There is also a 5th patch that Tom has already acked, but I have held
back (and will commit with these patches) since it will be complete only
with the bitpos change:
http://sourceware.org/ml/gdb-patches/2012-08/msg00562.html
I have also updated my repository of splint output reports here:
http://git.siddhesh.in/cgit.cgi/splint.git/
The reports generated earlier were splint-bitpos2.*, the noteworthy ones
being splint-bitpos2.locdiff.processed and
splint-bitpos2.locdiff.report. The new report generated is now called
splint-bitpos3.locdiff.processed.
There are a few improvements in the scripts that generate these reports
(splint-locdiff and splint-siddhesh-process-locdiff), the main one
being replacement of "arbitrary signed integer" with ssize_t and
"arbitrary unsigned integer" with size_t. Additionally, some more
warnings are ignored by the script, like assignments from int to
size_t, etc. that are safe.
There is an additional step of processing I have brought in (sorry),
which is done by checkreport.pl. The way to run it is as follows:
diff -U-1 \
splint-bitpos2.locdiff.processed \
splint-bitpos3.locdiff.processed | \
grep "^[-+](" | \
perl -e 'while(<>){s{^(.)(\([^:]+):([0-9]+)\):(.*)}{print("$2):$4\t\t$1$3\n")}egm}' | \
sort | \
./checkreport.pl | \
grep -v "^+++" | \
grep -v "^----" | \
grep "^+" | sed 's/^.\(.*\)/\1/' > report
This generated the 'report' file in the repo, which I copied over to
report.done and analyzed warnings. This report contains the new warnings
that are not in splint-bitpos2.locdiff.processed. The report to view is:
http://git.siddhesh.in/cgit.cgi/splint.git/tree/report.done
Now patches coming up next.
Regards,
Siddhesh
next reply other threads:[~2012-09-27 13:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 13:33 Siddhesh Poyarekar [this message]
2012-09-28 11:20 ` Jan Kratochvil
2012-09-28 11:40 ` Siddhesh Poyarekar
2012-09-28 12:06 ` Jan Kratochvil
2012-09-28 12:19 ` Siddhesh Poyarekar
2012-09-29 17:39 ` Jan Kratochvil
2012-09-29 18:12 ` Jan Kratochvil
2012-09-30 6:52 ` Jan Kratochvil
2012-10-01 5:21 ` Siddhesh Poyarekar
2012-10-01 6:14 ` Jan Kratochvil
2012-10-03 13:12 ` Siddhesh Poyarekar
2012-10-03 18:38 ` Jan Kratochvil
2012-10-04 7:20 ` Siddhesh Poyarekar
2012-10-03 19:56 ` Jan Kratochvil
2012-10-04 7:13 ` Jan Kratochvil
2012-10-21 7:36 ` Siddhesh Poyarekar
2012-10-22 20:45 ` Tom Tromey
2012-10-23 1:34 ` Jan Kratochvil
2012-10-23 1:58 ` Jan Kratochvil
2012-10-23 2:29 ` Siddhesh Poyarekar
2012-10-23 2:37 ` Jan Kratochvil
2012-10-23 2:38 ` Tom Tromey
2012-10-23 19:11 ` Jan Kratochvil
2012-10-24 18:33 ` Tom Tromey
2012-10-24 18:55 ` Jan Kratochvil
2012-10-24 20:18 ` Tom Tromey
2012-10-25 15:54 ` Jan Kratochvil
2012-10-25 16:52 ` Siddhesh Poyarekar
2012-11-06 20:01 ` Jan Kratochvil
2012-11-07 13:48 ` Jan Kratochvil
2012-11-13 19:46 ` Tom Tromey
2012-11-13 19:55 ` Jan Kratochvil
2012-11-01 15:24 ` Jan Kratochvil
2012-11-01 16:56 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120927190053.1e7de264@spoyarek \
--to=siddhesh@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox