From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25884 invoked by alias); 27 Sep 2012 13:33:14 -0000 Received: (qmail 25842 invoked by uid 22791); 27 Sep 2012 13:33:11 -0000 X-SWARE-Spam-Status: No, hits=-7.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 27 Sep 2012 13:32:58 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8RDWvvY027128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Sep 2012 09:32:57 -0400 Received: from spoyarek (spoyarek.pnq.redhat.com [10.65.192.188]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8RDWmc2011371 for ; Thu, 27 Sep 2012 09:32:56 -0400 Date: Thu, 27 Sep 2012 13:33:00 -0000 From: Siddhesh Poyarekar To: gdb-patches@sourceware.org Subject: [PATCH 0/4] bitpos expansion summary reloaded Message-ID: <20120927190053.1e7de264@spoyarek> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00628.txt.bz2 Hi, This is iteration (insert-large-number-here) of the bitpos expansion patch with all its reviews, etc. The patch is now split into 4 parts as follows: 1) The main bitpos and type.length expansion changes to generic code 2) Additional validation in some places to ensure that a size fits into memory (ensure_size_t) 3) Changes to watchpoint functions 4) bitpos and type length related changes to tdep files. I separated these out since they had a related pattern of change, i.e. pushing of variables on stack and getting/storing return values. The 4th part is new, but the content is not very different. Over time I have also picked out portions of the patch and pushed them as independent changes (some of which I rightly got flak for ;)) and as a result I have been able to shave off a total of about 1k lines off the patch, making it a bit easier to review. The split is also aimed at easing the review. There is also a 5th patch that Tom has already acked, but I have held back (and will commit with these patches) since it will be complete only with the bitpos change: http://sourceware.org/ml/gdb-patches/2012-08/msg00562.html I have also updated my repository of splint output reports here: http://git.siddhesh.in/cgit.cgi/splint.git/ The reports generated earlier were splint-bitpos2.*, the noteworthy ones being splint-bitpos2.locdiff.processed and splint-bitpos2.locdiff.report. The new report generated is now called splint-bitpos3.locdiff.processed. There are a few improvements in the scripts that generate these reports (splint-locdiff and splint-siddhesh-process-locdiff), the main one being replacement of "arbitrary signed integer" with ssize_t and "arbitrary unsigned integer" with size_t. Additionally, some more warnings are ignored by the script, like assignments from int to size_t, etc. that are safe. There is an additional step of processing I have brought in (sorry), which is done by checkreport.pl. The way to run it is as follows: diff -U-1 \ splint-bitpos2.locdiff.processed \ splint-bitpos3.locdiff.processed | \ grep "^[-+](" | \ perl -e 'while(<>){s{^(.)(\([^:]+):([0-9]+)\):(.*)}{print("$2):$4\t\t$1$3\n")}egm}' | \ sort | \ ./checkreport.pl | \ grep -v "^+++" | \ grep -v "^----" | \ grep "^+" | sed 's/^.\(.*\)/\1/' > report This generated the 'report' file in the repo, which I copied over to report.done and analyzed warnings. This report contains the new warnings that are not in splint-bitpos2.locdiff.processed. The report to view is: http://git.siddhesh.in/cgit.cgi/splint.git/tree/report.done Now patches coming up next. Regards, Siddhesh