From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tristan Gingold <gingold@adacore.com>,
"gdb-patches@sourceware.org ml"
<gdb-patches@sourceware.org>
Subject: Re: RFA: Try to include libunwind-ia64.h in libunwind-frame.h
Date: Tue, 14 Feb 2012 07:28:00 -0000 [thread overview]
Message-ID: <20120214072735.GA21362@host2.jankratochvil.net> (raw)
In-Reply-To: <4F396CDC.7020504@redhat.com>
On Mon, 13 Feb 2012 21:04:44 +0100, Pedro Alves wrote:
> On 02/13/2012 07:26 PM, Jan Kratochvil wrote:
> > On Mon, 13 Feb 2012 20:19:45 +0100, Pedro Alves wrote:
> >> On 02/13/2012 07:02 PM, Jan Kratochvil wrote:
> >>> It is required for ia64 but it can be used even with non-ia64 archs.
> >>
> >> How? AFAICS, no other target installs the libunwind sniffer. It's just
> >> dead code on other archs, if I'm reading the code correctly.
> >
> > I see now. I did not know. Sure in this case this patch of mine was wrong.
> > I will therefore make libunwind usable only with ia64, this will be different
> > patch removing some parts of gdb/ code.
>
> I was only thinking of the below. Would this work for everyone?
>
> I don't have a cross build of libunwind for ia64 handy, but I assume
> this works, given the previous patches...
the patch does not apply to HEAD, with hand-application and
CPPFLAGS="-I/tmp/libunwind-root-ia64/include" CFLAGS="-g $CPPFLAGS" LDFLAGS=-L/tmp/libunwind-root-ia64/lib ./configure --enable-targets=all
getting:
ia64-tdep.c: In function ‘ia64_pseudo_register_read’:
ia64-tdep.c:946:7: error: implicit declaration of function ‘libunwind_is_initialized’ [-Werror=implicit-function-declaration]
ia64-tdep.c:947:4: error: implicit declaration of function ‘libunwind_get_reg_special’ [-Werror=implicit-function-declaration]
config.h:
/* #undef HAVE_LIBUNWIND */
#define HAVE_LIBUNWIND_IA64_H 1
If the non-ia64 libunwind support is therefore really removed the dead code in
libunwind-frame.c should be also removed with some comments making it ia64
specific.
I believe the original goal was to make the libunwind support in GDB
arch-independent but it has been done only half-way and I agree it is OK to
make libunwind support really ia64-only.
RFA: libunwind basic support
http://sourceware.org/ml/gdb-patches/2003-10/msg00504.html
+ AC_CHECK_HEADERS(libunwind-ia64.h)
+ if x"$ac_cv_header_libunwind_ia64_h" = xyes; then
This should use threfore AC_CHECK_HEADER.
Regards,
Jan
next prev parent reply other threads:[~2012-02-14 7:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 16:32 Tristan Gingold
2012-02-10 12:31 ` Jan Kratochvil
2012-02-10 13:15 ` Tristan Gingold
2012-02-10 13:21 ` Jan Kratochvil
2012-02-10 13:27 ` Joel Brobecker
2012-02-10 13:45 ` Tristan Gingold
2012-02-10 14:04 ` Tristan Gingold
2012-02-10 14:09 ` Jan Kratochvil
2012-02-10 14:14 ` Tristan Gingold
2012-02-10 18:27 ` Jan Kratochvil
2012-02-10 18:34 ` Pedro Alves
2012-02-10 18:44 ` Jan Kratochvil
2012-02-10 18:59 ` Pedro Alves
2012-02-10 19:38 ` Jan Kratochvil
2012-02-11 14:10 ` Jan Kratochvil
2012-02-13 8:41 ` Tristan Gingold
2012-02-13 18:58 ` Pedro Alves
2012-02-13 19:03 ` Jan Kratochvil
2012-02-13 19:20 ` Pedro Alves
2012-02-13 19:27 ` Jan Kratochvil
2012-02-13 20:05 ` Pedro Alves
2012-02-14 7:28 ` Jan Kratochvil [this message]
2012-02-14 12:14 ` Pedro Alves
2012-02-14 14:36 ` Jan Kratochvil
2012-02-14 14:53 ` Pedro Alves
2012-02-20 20:54 ` Jan Kratochvil
2012-02-20 22:30 ` Pedro Alves
2012-02-20 22:37 ` Joel Brobecker
2012-02-20 22:39 ` Joel Brobecker
2012-02-20 22:57 ` Pedro Alves
2012-02-20 23:20 ` Joel Brobecker
2012-02-21 6:48 ` Jan Kratochvil
2012-02-21 13:36 ` Pedro Alves
2012-02-21 19:10 ` Tom Tromey
2012-02-22 7:56 ` Tristan Gingold
2012-02-22 14:52 ` Jan Kratochvil
2012-02-21 20:18 ` Jan Kratochvil
2012-02-21 20:43 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214072735.GA21362@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox