From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Tristan Gingold <gingold@adacore.com>,
"gdb-patches@sourceware.org ml"
<gdb-patches@sourceware.org>
Subject: Re: RFA: Try to include libunwind-ia64.h in libunwind-frame.h
Date: Fri, 10 Feb 2012 19:38:00 -0000 [thread overview]
Message-ID: <20120210193724.GA14314@host2.jankratochvil.net> (raw)
In-Reply-To: <4F3568DE.4000906@redhat.com>
On Fri, 10 Feb 2012 19:58:38 +0100, Pedro Alves wrote:
> The issue is that you're using $target to detect when to include
> libunwind-ia64.h. That's broken for the --enable-targets=all, or
> --target=x86_64-foo --enable-target=ia64-xxx cases, when --target is _not_
> ia64-*.
OK, you are right, I thought it is good enough but I agree it is not.
> That is, it looks to me that the fix should be to make sure we include
> libunwind-ia64.h in ia64 relative code, no matter the $target.
The libunwind interface in GDB (libunwind-frame.c) is not ia64 specific in any
way. And while you can have libunwind-ia64.so, libunwind-x86_64.so and others
installed in parallel libunwind-frame.c has only one instance in GDB and can
load only one of these.
Also the architecture of libunwind is not directly mapped from configure
architectures. For example libunwind has x86, GDB has i386.
Maybe Tristan could prepare a better patch?
Thanks,
Jan
next prev parent reply other threads:[~2012-02-10 19:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 16:32 Tristan Gingold
2012-02-10 12:31 ` Jan Kratochvil
2012-02-10 13:15 ` Tristan Gingold
2012-02-10 13:21 ` Jan Kratochvil
2012-02-10 13:27 ` Joel Brobecker
2012-02-10 13:45 ` Tristan Gingold
2012-02-10 14:04 ` Tristan Gingold
2012-02-10 14:09 ` Jan Kratochvil
2012-02-10 14:14 ` Tristan Gingold
2012-02-10 18:27 ` Jan Kratochvil
2012-02-10 18:34 ` Pedro Alves
2012-02-10 18:44 ` Jan Kratochvil
2012-02-10 18:59 ` Pedro Alves
2012-02-10 19:38 ` Jan Kratochvil [this message]
2012-02-11 14:10 ` Jan Kratochvil
2012-02-13 8:41 ` Tristan Gingold
2012-02-13 18:58 ` Pedro Alves
2012-02-13 19:03 ` Jan Kratochvil
2012-02-13 19:20 ` Pedro Alves
2012-02-13 19:27 ` Jan Kratochvil
2012-02-13 20:05 ` Pedro Alves
2012-02-14 7:28 ` Jan Kratochvil
2012-02-14 12:14 ` Pedro Alves
2012-02-14 14:36 ` Jan Kratochvil
2012-02-14 14:53 ` Pedro Alves
2012-02-20 20:54 ` Jan Kratochvil
2012-02-20 22:30 ` Pedro Alves
2012-02-20 22:37 ` Joel Brobecker
2012-02-20 22:39 ` Joel Brobecker
2012-02-20 22:57 ` Pedro Alves
2012-02-20 23:20 ` Joel Brobecker
2012-02-21 6:48 ` Jan Kratochvil
2012-02-21 13:36 ` Pedro Alves
2012-02-21 19:10 ` Tom Tromey
2012-02-22 7:56 ` Tristan Gingold
2012-02-22 14:52 ` Jan Kratochvil
2012-02-21 20:18 ` Jan Kratochvil
2012-02-21 20:43 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210193724.GA14314@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox