From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18127 invoked by alias); 10 Feb 2012 19:38:07 -0000 Received: (qmail 18064 invoked by uid 22791); 10 Feb 2012 19:38:06 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Feb 2012 19:37:50 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1AJbSPx004344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Feb 2012 14:37:28 -0500 Received: from host2.jankratochvil.net (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1AJbOew026880 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 10 Feb 2012 14:37:27 -0500 Date: Fri, 10 Feb 2012 19:38:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Tristan Gingold , "gdb-patches@sourceware.org ml" Subject: Re: RFA: Try to include libunwind-ia64.h in libunwind-frame.h Message-ID: <20120210193724.GA14314@host2.jankratochvil.net> References: <5D1CD28F-F628-475C-B6D8-5FCBF5290C63@adacore.com> <20120210182705.GA32459@host2.jankratochvil.net> <4F3562FE.7050106@redhat.com> <20120210184352.GA1380@host2.jankratochvil.net> <4F3568DE.4000906@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F3568DE.4000906@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00220.txt.bz2 On Fri, 10 Feb 2012 19:58:38 +0100, Pedro Alves wrote: > The issue is that you're using $target to detect when to include > libunwind-ia64.h. That's broken for the --enable-targets=all, or > --target=x86_64-foo --enable-target=ia64-xxx cases, when --target is _not_ > ia64-*. OK, you are right, I thought it is good enough but I agree it is not. > That is, it looks to me that the fix should be to make sure we include > libunwind-ia64.h in ia64 relative code, no matter the $target. The libunwind interface in GDB (libunwind-frame.c) is not ia64 specific in any way. And while you can have libunwind-ia64.so, libunwind-x86_64.so and others installed in parallel libunwind-frame.c has only one instance in GDB and can load only one of these. Also the architecture of libunwind is not directly mapped from configure architectures. For example libunwind has x86, GDB has i386. Maybe Tristan could prepare a better patch? Thanks, Jan