From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30557 invoked by alias); 14 Feb 2012 07:28:10 -0000 Received: (qmail 30547 invoked by uid 22791); 14 Feb 2012 07:28:09 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Feb 2012 07:27:54 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1E7Ree5025877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 14 Feb 2012 02:27:41 -0500 Received: from host2.jankratochvil.net (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1E7RaK7004623 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 14 Feb 2012 02:27:39 -0500 Date: Tue, 14 Feb 2012 07:28:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: Tristan Gingold , "gdb-patches@sourceware.org ml" Subject: Re: RFA: Try to include libunwind-ia64.h in libunwind-frame.h Message-ID: <20120214072735.GA21362@host2.jankratochvil.net> References: <5D1CD28F-F628-475C-B6D8-5FCBF5290C63@adacore.com> <20120210182705.GA32459@host2.jankratochvil.net> <4F3562FE.7050106@redhat.com> <20120211140919.GA24043@host2.jankratochvil.net> <4F395D17.5070303@redhat.com> <20120213190223.GA8851@host2.jankratochvil.net> <4F396251.9020409@redhat.com> <20120213192652.GA11522@host2.jankratochvil.net> <4F396CDC.7020504@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Disposition: inline In-Reply-To: <4F396CDC.7020504@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00250.txt.bz2 On Mon, 13 Feb 2012 21:04:44 +0100, Pedro Alves wrote: > On 02/13/2012 07:26 PM, Jan Kratochvil wrote: > > On Mon, 13 Feb 2012 20:19:45 +0100, Pedro Alves wrote: > >> On 02/13/2012 07:02 PM, Jan Kratochvil wrote: > >>> It is required for ia64 but it can be used even with non-ia64 archs. > >> > >> How? AFAICS, no other target installs the libunwind sniffer. It's just > >> dead code on other archs, if I'm reading the code correctly. > > > > I see now. I did not know. Sure in this case this patch of mine was wrong. > > I will therefore make libunwind usable only with ia64, this will be different > > patch removing some parts of gdb/ code. > > I was only thinking of the below. Would this work for everyone? > > I don't have a cross build of libunwind for ia64 handy, but I assume > this works, given the previous patches... the patch does not apply to HEAD, with hand-application and CPPFLAGS="-I/tmp/libunwind-root-ia64/include" CFLAGS="-g $CPPFLAGS" LDFLAGS=-L/tmp/libunwind-root-ia64/lib ./configure --enable-targets=all getting: ia64-tdep.c: In function ‘ia64_pseudo_register_read’: ia64-tdep.c:946:7: error: implicit declaration of function ‘libunwind_is_initialized’ [-Werror=implicit-function-declaration] ia64-tdep.c:947:4: error: implicit declaration of function ‘libunwind_get_reg_special’ [-Werror=implicit-function-declaration] config.h: /* #undef HAVE_LIBUNWIND */ #define HAVE_LIBUNWIND_IA64_H 1 If the non-ia64 libunwind support is therefore really removed the dead code in libunwind-frame.c should be also removed with some comments making it ia64 specific. I believe the original goal was to make the libunwind support in GDB arch-independent but it has been done only half-way and I agree it is OK to make libunwind support really ia64-only. RFA: libunwind basic support http://sourceware.org/ml/gdb-patches/2003-10/msg00504.html + AC_CHECK_HEADERS(libunwind-ia64.h) + if x"$ac_cv_header_libunwind_ia64_h" = xyes; then This should use threfore AC_CHECK_HEADER. Regards, Jan