From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: hjl.tools@gmail.com, gdb-patches@sourceware.org
Subject: Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target
Date: Thu, 08 Sep 2011 15:38:00 -0000 [thread overview]
Message-ID: <20110908153454.GE23706@host1.jankratochvil.net> (raw)
In-Reply-To: <201108282105.p7SL5YAL006825@glazunov.sibelius.xs4all.nl>
On Sun, 28 Aug 2011 23:05:34 +0200, Mark Kettenis wrote:
> > From: Jan Kratochvil <jan.kratochvil@redhat.com>
> > x32 uses triple x86_64-x32-linux* which matches x86_64-*-*.
>
> Uh, that's wrong. The middle part if the target triplet is supposed
> to be the hardware vendor. For i386/amd64 this is pretty much
> meaningles, but attaching a new meaning to it would be a mistake.
>
> Fortunately, your diff doesn't really depend on this. But I think you
> should adjust the comments in the code.
The triple x86_64-x32-linux* is a reality in binutils, gcc etc., I believe if
it should be changed GDB is not the place to start such change.
And the comments should reflect the reality.
OK to check it in as is?
Thanks,
Jan
next prev parent reply other threads:[~2011-09-08 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 9:26 [obv] testsuite: gdb.trace/*: Use is_lp64_target Jan Kratochvil
2011-08-26 13:48 ` H.J. Lu
2011-08-26 15:37 ` Jan Kratochvil
2011-08-26 15:59 ` H.J. Lu
2011-08-28 20:07 ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target] Jan Kratochvil
2011-08-28 21:06 ` Mark Kettenis
2011-09-08 15:38 ` Jan Kratochvil [this message]
2011-09-08 15:57 ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target Pedro Alves
2011-09-08 17:47 ` Jan Kratochvil
2011-09-08 18:22 ` Mark Kettenis
2011-09-08 16:01 ` Mark Kettenis
2011-09-08 17:16 ` H.J. Lu
2011-08-28 21:19 ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target] Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110908153454.GE23706@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox