Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target
Date: Fri, 26 Aug 2011 15:37:00 -0000	[thread overview]
Message-ID: <20110826153716.GA14293@host1.jankratochvil.net> (raw)
In-Reply-To: <CAMe9rOpqQySk0Jdhgp9NPq6QAaa-nobrD1DBNuyHzXtNEcuZcQ@mail.gmail.com>

On Fri, 26 Aug 2011 15:48:33 +0200, H.J. Lu wrote:
> On Fri, Aug 26, 2011 at 2:25 AM, Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> > -if [istarget "x86_64-*"] then {
> > +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
> >     set fpreg "\$rbp"
> > -} elseif [istarget "i?86-*"] then {
> > +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
> >     set fpreg "\$ebp"
> >  } else {
> >     set fpreg "\$fp"
> >
> 
> That is wrong for x32. X32 isn't LP64, but has 64bit registers.

I agree.  I tried to fix all the [is_lp64_target] vs. ![is_ilp32_target] cases
for x86* in the testsuite but I am not sure how x32* behaves, do you have
some qemu/kvm image with x32* toolchain?  I could not fina any on:
	http://sites.google.com/site/x32abi/


Thanks,
Jan


  reply	other threads:[~2011-08-26 15:37 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26  9:26 Jan Kratochvil
2011-08-26 13:48 ` H.J. Lu
2011-08-26 15:37   ` Jan Kratochvil [this message]
2011-08-26 15:59     ` H.J. Lu
2011-08-28 20:07   ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target] Jan Kratochvil
2011-08-28 21:06     ` Mark Kettenis
2011-09-08 15:38       ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target Jan Kratochvil
2011-09-08 15:57         ` Pedro Alves
2011-09-08 17:47           ` Jan Kratochvil
2011-09-08 18:22             ` Mark Kettenis
2011-09-08 16:01         ` Mark Kettenis
2011-09-08 17:16         ` H.J. Lu
2011-08-28 21:19     ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target] Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110826153716.GA14293@host1.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox