From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22418 invoked by alias); 26 Aug 2011 15:37:41 -0000 Received: (qmail 22194 invoked by uid 22791); 26 Aug 2011 15:37:38 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 15:37:21 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7QFbKKX017029 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Aug 2011 11:37:20 -0400 Received: from host1.jankratochvil.net (ovpn-116-38.ams2.redhat.com [10.36.116.38]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7QFbHfJ006860 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 26 Aug 2011 11:37:19 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p7QFbGlp014514; Fri, 26 Aug 2011 17:37:16 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p7QFbGdg014513; Fri, 26 Aug 2011 17:37:16 +0200 Date: Fri, 26 Aug 2011 15:37:00 -0000 From: Jan Kratochvil To: "H.J. Lu" Cc: gdb-patches@sourceware.org Subject: Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target Message-ID: <20110826153716.GA14293@host1.jankratochvil.net> References: <20110826092539.GA23720@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00495.txt.bz2 On Fri, 26 Aug 2011 15:48:33 +0200, H.J. Lu wrote: > On Fri, Aug 26, 2011 at 2:25 AM, Jan Kratochvil wrote: > > -if [istarget "x86_64-*"] then { > > +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then { > >     set fpreg "\$rbp" > > -} elseif [istarget "i?86-*"] then { > > +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { > >     set fpreg "\$ebp" > >  } else { > >     set fpreg "\$fp" > > > > That is wrong for x32. X32 isn't LP64, but has 64bit registers. I agree. I tried to fix all the [is_lp64_target] vs. ![is_ilp32_target] cases for x86* in the testsuite but I am not sure how x32* behaves, do you have some qemu/kvm image with x32* toolchain? I could not fina any on: http://sites.google.com/site/x32abi/ Thanks, Jan