From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
Cc: hjl.tools@gmail.com, gdb-patches@sourceware.org
Subject: Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target]
Date: Sun, 28 Aug 2011 21:06:00 -0000 [thread overview]
Message-ID: <201108282105.p7SL5YAL006825@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20110828200640.GA10351@host1.jankratochvil.net> (message from Jan Kratochvil on Sun, 28 Aug 2011 22:06:40 +0200)
> Date: Sun, 28 Aug 2011 22:06:40 +0200
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
>
> On Fri, 26 Aug 2011 15:48:33 +0200, H.J. Lu wrote:
> > That is wrong for x32. X32 isn't LP64, but has 64bit registers.
>
> x32 uses triple x86_64-x32-linux* which matches x86_64-*-*.
Uh, that's wrong. The middle part if the target triplet is supposed
to be the hardware vendor. For i386/amd64 this is pretty much
meaningles, but attaching a new meaning to it would be a mistake.
Fortunately, your diff doesn't really depend on this. But I think you
should adjust the comments in the code.
> gdb/testsuite/
> 2011-08-28 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix compatibility with x32 arch.
> * testsuite/gdb.dwarf2/typeddwarf.exp: Check also is_lp64_target.
> * testsuite/gdb.trace/backtrace.exp: Use is_amd64_regs_target and
> is_x86_like_target.
> * testsuite/gdb.trace/collection.exp: Likewise.
> * testsuite/gdb.trace/report.exp: Likewise.
> * testsuite/gdb.trace/unavailable.exp: Likewise.
> * testsuite/gdb.trace/while-dyn.exp: Likewise.
> * testsuite/lib/gdb.exp (is_amd64_regs_target): New function.
> (is_x86_like_target): Check also is_amd64_regs_target.
next prev parent reply other threads:[~2011-08-28 21:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 9:26 [obv] testsuite: gdb.trace/*: Use is_lp64_target Jan Kratochvil
2011-08-26 13:48 ` H.J. Lu
2011-08-26 15:37 ` Jan Kratochvil
2011-08-26 15:59 ` H.J. Lu
2011-08-28 20:07 ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target] Jan Kratochvil
2011-08-28 21:06 ` Mark Kettenis [this message]
2011-09-08 15:38 ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target Jan Kratochvil
2011-09-08 15:57 ` Pedro Alves
2011-09-08 17:47 ` Jan Kratochvil
2011-09-08 18:22 ` Mark Kettenis
2011-09-08 16:01 ` Mark Kettenis
2011-09-08 17:16 ` H.J. Lu
2011-08-28 21:19 ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target] Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108282105.p7SL5YAL006825@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox