From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3187 invoked by alias); 28 Aug 2011 21:06:07 -0000 Received: (qmail 3179 invoked by uid 22791); 28 Aug 2011 21:06:07 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 28 Aug 2011 21:05:50 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id p7SL5aDW025449; Sun, 28 Aug 2011 23:05:37 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id p7SL5YAL006825; Sun, 28 Aug 2011 23:05:34 +0200 (CEST) Date: Sun, 28 Aug 2011 21:06:00 -0000 Message-Id: <201108282105.p7SL5YAL006825@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: jan.kratochvil@redhat.com CC: hjl.tools@gmail.com, gdb-patches@sourceware.org In-reply-to: <20110828200640.GA10351@host1.jankratochvil.net> (message from Jan Kratochvil on Sun, 28 Aug 2011 22:06:40 +0200) Subject: Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target] References: <20110826092539.GA23720@host1.jankratochvil.net> <20110828200640.GA10351@host1.jankratochvil.net> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00554.txt.bz2 > Date: Sun, 28 Aug 2011 22:06:40 +0200 > From: Jan Kratochvil > > On Fri, 26 Aug 2011 15:48:33 +0200, H.J. Lu wrote: > > That is wrong for x32. X32 isn't LP64, but has 64bit registers. > > x32 uses triple x86_64-x32-linux* which matches x86_64-*-*. Uh, that's wrong. The middle part if the target triplet is supposed to be the hardware vendor. For i386/amd64 this is pretty much meaningles, but attaching a new meaning to it would be a mistake. Fortunately, your diff doesn't really depend on this. But I think you should adjust the comments in the code. > gdb/testsuite/ > 2011-08-28 Jan Kratochvil > > Fix compatibility with x32 arch. > * testsuite/gdb.dwarf2/typeddwarf.exp: Check also is_lp64_target. > * testsuite/gdb.trace/backtrace.exp: Use is_amd64_regs_target and > is_x86_like_target. > * testsuite/gdb.trace/collection.exp: Likewise. > * testsuite/gdb.trace/report.exp: Likewise. > * testsuite/gdb.trace/unavailable.exp: Likewise. > * testsuite/gdb.trace/while-dyn.exp: Likewise. > * testsuite/lib/gdb.exp (is_amd64_regs_target): New function. > (is_x86_like_target): Check also is_amd64_regs_target.