From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [obv] testsuite: gdb.trace/*: Use is_lp64_target
Date: Fri, 26 Aug 2011 09:26:00 -0000 [thread overview]
Message-ID: <20110826092539.GA23720@host1.jankratochvil.net> (raw)
Hi,
checked in as obvious.
There are always these FAILs in all the cases, I did not investigate them more.
FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argc
FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argi
FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argf
FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argd
FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argarray
Tested on {x86_64,x86_64-m32,i686}-fedora16pre-linux-gnu.
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2011-08/msg00111.html
--- src/gdb/testsuite/ChangeLog 2011/08/18 16:19:00 1.2837
+++ src/gdb/testsuite/ChangeLog 2011/08/26 09:20:43 1.2838
@@ -1,3 +1,11 @@
+2011-08-26 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.trace/backtrace.exp: Use is_lp64_target to check 64bit target.
+ * gdb.trace/collection.exp: Likewise.
+ * gdb.trace/report.exp: Likewise.
+ * gdb.trace/unavailable.exp: Likewise.
+ * gdb.trace/while-dyn.exp: Likewise.
+
2011-08-18 Keith Seitz <keiths@redhat.com>
PR c++/12266
--- src/gdb/testsuite/gdb.trace/backtrace.exp 2011/01/01 15:33:50 1.18
+++ src/gdb/testsuite/gdb.trace/backtrace.exp 2011/08/26 09:20:44 1.19
@@ -150,10 +150,10 @@
"$tdp4" \
"collect \$regs, \$args, \$locs" "^$"
-if [istarget "x86_64-*"] then {
+if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
set fpreg "\$rbp"
set spreg "\$rsp"
-} elseif [istarget "i?86-*"] then {
+} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
set fpreg "\$ebp"
set spreg "\$esp"
} else {
--- src/gdb/testsuite/gdb.trace/collection.exp 2011/02/16 18:07:58 1.24
+++ src/gdb/testsuite/gdb.trace/collection.exp 2011/08/26 09:20:44 1.25
@@ -45,11 +45,11 @@
set ws "\[\r\n\t \]+"
set cr "\[\r\n\]+"
-if [istarget "x86_64-*"] then {
+if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
set fpreg "rbp"
set spreg "rsp"
set pcreg "rip"
-} elseif [istarget "i?86-*"] then {
+} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
set fpreg "ebp"
set spreg "esp"
set pcreg "eip"
--- src/gdb/testsuite/gdb.trace/report.exp 2011/03/07 20:25:57 1.19
+++ src/gdb/testsuite/gdb.trace/report.exp 2011/08/26 09:20:44 1.20
@@ -159,11 +159,11 @@
"$tdp4" \
"collect \$locs" "^$"
-if [istarget "x86_64-*"] then {
+if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
set fpreg "rbp"
set spreg "rsp"
set pcreg "rip"
-} elseif [istarget "i?86-*"] then {
+} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
set fpreg "ebp"
set spreg "esp"
set pcreg "eip"
--- src/gdb/testsuite/gdb.trace/unavailable.exp 2011/08/05 15:17:59 1.9
+++ src/gdb/testsuite/gdb.trace/unavailable.exp 2011/08/26 09:20:44 1.10
@@ -30,11 +30,11 @@
set ws "\[\r\n\t \]+"
set cr "\[\r\n\]+"
-if [istarget "x86_64-*"] then {
+if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
set fpreg "rbp"
set spreg "rsp"
set pcreg "rip"
-} elseif [istarget "i?86-*"] then {
+} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
set fpreg "ebp"
set spreg "esp"
set pcreg "eip"
@@ -295,12 +295,12 @@
# Test reading uncollected pseudo-registers. The set of which
# depends on target.
- if [istarget "x86_64-*"] then {
+ if {$pcreg == "rip"} then {
# Check the raw register first.
test_register_unavailable "\$rax"
test_register_unavailable "\$eax"
test_register_unavailable "\$ax"
- } elseif [istarget "i?86-*"] then {
+ } elseif {$pcreg == "eip"} then {
# Check the raw register first.
test_register_unavailable "\$eax"
test_register_unavailable "\$ax"
--- src/gdb/testsuite/gdb.trace/while-dyn.exp 2011/01/01 15:33:50 1.18
+++ src/gdb/testsuite/gdb.trace/while-dyn.exp 2011/08/26 09:20:44 1.19
@@ -52,9 +52,9 @@
# test while-stepping dynamically (live target)
#
-if [istarget "x86_64-*"] then {
+if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
set fpreg "\$rbp"
-} elseif [istarget "i?86-*"] then {
+} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
set fpreg "\$ebp"
} else {
set fpreg "\$fp"
next reply other threads:[~2011-08-26 9:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 9:26 Jan Kratochvil [this message]
2011-08-26 13:48 ` H.J. Lu
2011-08-26 15:37 ` Jan Kratochvil
2011-08-26 15:59 ` H.J. Lu
2011-08-28 20:07 ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target] Jan Kratochvil
2011-08-28 21:06 ` Mark Kettenis
2011-09-08 15:38 ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target Jan Kratochvil
2011-09-08 15:57 ` Pedro Alves
2011-09-08 17:47 ` Jan Kratochvil
2011-09-08 18:22 ` Mark Kettenis
2011-09-08 16:01 ` Mark Kettenis
2011-09-08 17:16 ` H.J. Lu
2011-08-28 21:19 ` [patch] testsuite: Fix x32, introduce is_amd64_regs_target [Re: [obv] testsuite: gdb.trace/*: Use is_lp64_target] Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110826092539.GA23720@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox