From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1843 invoked by alias); 26 Aug 2011 09:26:06 -0000 Received: (qmail 1794 invoked by uid 22791); 26 Aug 2011 09:26:05 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Aug 2011 09:25:43 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p7Q9Phij024637 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Aug 2011 05:25:43 -0400 Received: from host1.jankratochvil.net (ovpn-116-38.ams2.redhat.com [10.36.116.38]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p7Q9PeBH006453 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 26 Aug 2011 05:25:42 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p7Q9PeGl021652 for ; Fri, 26 Aug 2011 11:25:40 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p7Q9PdFj021645 for gdb-patches@sourceware.org; Fri, 26 Aug 2011 11:25:39 +0200 Date: Fri, 26 Aug 2011 09:26:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [obv] testsuite: gdb.trace/*: Use is_lp64_target Message-ID: <20110826092539.GA23720@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-08/txt/msg00478.txt.bz2 Hi, checked in as obvious. There are always these FAILs in all the cases, I did not investigate them more. FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argc FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argi FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argf FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argd FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argarray Tested on {x86_64,x86_64-m32,i686}-fedora16pre-linux-gnu. Thanks, Jan http://sourceware.org/ml/gdb-cvs/2011-08/msg00111.html --- src/gdb/testsuite/ChangeLog 2011/08/18 16:19:00 1.2837 +++ src/gdb/testsuite/ChangeLog 2011/08/26 09:20:43 1.2838 @@ -1,3 +1,11 @@ +2011-08-26 Jan Kratochvil + + * gdb.trace/backtrace.exp: Use is_lp64_target to check 64bit target. + * gdb.trace/collection.exp: Likewise. + * gdb.trace/report.exp: Likewise. + * gdb.trace/unavailable.exp: Likewise. + * gdb.trace/while-dyn.exp: Likewise. + 2011-08-18 Keith Seitz PR c++/12266 --- src/gdb/testsuite/gdb.trace/backtrace.exp 2011/01/01 15:33:50 1.18 +++ src/gdb/testsuite/gdb.trace/backtrace.exp 2011/08/26 09:20:44 1.19 @@ -150,10 +150,10 @@ "$tdp4" \ "collect \$regs, \$args, \$locs" "^$" -if [istarget "x86_64-*"] then { +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then { set fpreg "\$rbp" set spreg "\$rsp" -} elseif [istarget "i?86-*"] then { +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { set fpreg "\$ebp" set spreg "\$esp" } else { --- src/gdb/testsuite/gdb.trace/collection.exp 2011/02/16 18:07:58 1.24 +++ src/gdb/testsuite/gdb.trace/collection.exp 2011/08/26 09:20:44 1.25 @@ -45,11 +45,11 @@ set ws "\[\r\n\t \]+" set cr "\[\r\n\]+" -if [istarget "x86_64-*"] then { +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then { set fpreg "rbp" set spreg "rsp" set pcreg "rip" -} elseif [istarget "i?86-*"] then { +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { set fpreg "ebp" set spreg "esp" set pcreg "eip" --- src/gdb/testsuite/gdb.trace/report.exp 2011/03/07 20:25:57 1.19 +++ src/gdb/testsuite/gdb.trace/report.exp 2011/08/26 09:20:44 1.20 @@ -159,11 +159,11 @@ "$tdp4" \ "collect \$locs" "^$" -if [istarget "x86_64-*"] then { +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then { set fpreg "rbp" set spreg "rsp" set pcreg "rip" -} elseif [istarget "i?86-*"] then { +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { set fpreg "ebp" set spreg "esp" set pcreg "eip" --- src/gdb/testsuite/gdb.trace/unavailable.exp 2011/08/05 15:17:59 1.9 +++ src/gdb/testsuite/gdb.trace/unavailable.exp 2011/08/26 09:20:44 1.10 @@ -30,11 +30,11 @@ set ws "\[\r\n\t \]+" set cr "\[\r\n\]+" -if [istarget "x86_64-*"] then { +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then { set fpreg "rbp" set spreg "rsp" set pcreg "rip" -} elseif [istarget "i?86-*"] then { +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { set fpreg "ebp" set spreg "esp" set pcreg "eip" @@ -295,12 +295,12 @@ # Test reading uncollected pseudo-registers. The set of which # depends on target. - if [istarget "x86_64-*"] then { + if {$pcreg == "rip"} then { # Check the raw register first. test_register_unavailable "\$rax" test_register_unavailable "\$eax" test_register_unavailable "\$ax" - } elseif [istarget "i?86-*"] then { + } elseif {$pcreg == "eip"} then { # Check the raw register first. test_register_unavailable "\$eax" test_register_unavailable "\$ax" --- src/gdb/testsuite/gdb.trace/while-dyn.exp 2011/01/01 15:33:50 1.18 +++ src/gdb/testsuite/gdb.trace/while-dyn.exp 2011/08/26 09:20:44 1.19 @@ -52,9 +52,9 @@ # test while-stepping dynamically (live target) # -if [istarget "x86_64-*"] then { +if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then { set fpreg "\$rbp" -} elseif [istarget "i?86-*"] then { +} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then { set fpreg "\$ebp" } else { set fpreg "\$fp"