From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24341 invoked by alias); 8 Sep 2011 15:35:16 -0000 Received: (qmail 24228 invoked by uid 22791); 8 Sep 2011 15:35:15 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Sep 2011 15:34:58 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p88FYvRP018220 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Sep 2011 11:34:57 -0400 Received: from host1.jankratochvil.net (ovpn-116-38.ams2.redhat.com [10.36.116.38]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p88FYtaF006227 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 8 Sep 2011 11:34:57 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p88FYsTo000381; Thu, 8 Sep 2011 17:34:54 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p88FYsnd000375; Thu, 8 Sep 2011 17:34:54 +0200 Date: Thu, 08 Sep 2011 15:38:00 -0000 From: Jan Kratochvil To: Mark Kettenis Cc: hjl.tools@gmail.com, gdb-patches@sourceware.org Subject: Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target Message-ID: <20110908153454.GE23706@host1.jankratochvil.net> References: <20110826092539.GA23720@host1.jankratochvil.net> <20110828200640.GA10351@host1.jankratochvil.net> <201108282105.p7SL5YAL006825@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201108282105.p7SL5YAL006825@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00140.txt.bz2 On Sun, 28 Aug 2011 23:05:34 +0200, Mark Kettenis wrote: > > From: Jan Kratochvil > > x32 uses triple x86_64-x32-linux* which matches x86_64-*-*. > > Uh, that's wrong. The middle part if the target triplet is supposed > to be the hardware vendor. For i386/amd64 this is pretty much > meaningles, but attaching a new meaning to it would be a mistake. > > Fortunately, your diff doesn't really depend on this. But I think you > should adjust the comments in the code. The triple x86_64-x32-linux* is a reality in binutils, gcc etc., I believe if it should be changed GDB is not the place to start such change. And the comments should reflect the reality. OK to check it in as is? Thanks, Jan