Re: [RFA 6/8] New port: TI C6x: gdbserver

[Pedro Alves <pedro@codesourcery.com>]

Thanks.  This code in this version looked good to me,
with a few nits pointed out below that I noticed this time
around.

The new docs bits will need to be reviewed by Eli.  I
have one comment to them:

> @@ -36854,6 +36854,7 @@ registers using the capitalization used in the description.
>  * MIPS Features::
>  * M68K Features::
>  * PowerPC Features::
> +* C6x Features::
>  @end menu

The list looked alpha sorted to me.



> +static int tic6x_regmap_c64x[] = {
> +  /* A0 - A15 */
> +  51, 50, 53, 52, 55, 54, 57, 56,
> +  59, 58, 61, 60, 63, 62, 65, 64,
> +  /* B0 - B15 */
> +  21, 20, 23, 22, 25, 24, 27, 26,
> +  29, 28, 31, 30, 33, 32, 67, 66,
> +  /* CSR PC */
> +  3, 2,
> +  /* A16 - A31 */
> +  35, 34, 37, 36, 39, 38, 41, 40,
> +  43, 42, 45, 44, 47, 46, 49, 48,
> +  /* B16 - B32 */

B31, I think?

> +  5,  4,  7,  6,  9,  8,  11, 10,
> +  13, 12, 15, 14, 17, 16, 19, 18,
> +  -1, -1, -1

> +  /* CSR PC*/

Missing space. (several places)

> +  *base = (void *) ((char *)*base - idx);

Missing space after (char *)

> +#ifdef HAVE_PTRACE_GETREGS
> +

I wonder if there ever was a c6x kernel that
didn't have this.

-- 
Pedro Alves