From: Eli Zaretskii <eliz@gnu.org>
To: Yao Qi <yao@codesourcery.com>
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [RFA 6/8] New port: TI C6x: gdbserver
Date: Wed, 27 Jul 2011 07:01:00 -0000 [thread overview]
Message-ID: <E1QlwUl-0001EN-PE@fencepost.gnu.org> (raw)
In-Reply-To: <4E2F89D4.7050401@codesourcery.com> (message from Yao Qi on Wed, 27 Jul 2011 11:45:24 +0800)
> Date: Wed, 27 Jul 2011 11:45:24 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: gdb-patches@sourceware.org
>
> I've sorted this into alpha-beta order in new patch. Eli, could you
> have a review on new document part in this patch?
Here goes:
> gdb/doc/
> * gdb.texinfo: Document C6x features.
You need to state the name of the node here, see the other log
entries.
> +@node C6x Features
> +@subsection C6x Features
How about using a more full/explicit name of the target in the
subsection name? After all, C6x is just an abbreviation/acronym. I
would assume that users of these targets will at least expect to see
something like TMS320C6x, if not "Texas Instruments".
> +@cindex target descriptions, C6x features
Same here: I would suggest an additional @cindex entry with the full
name.
> +The @samp{org.gnu.gdb.tic6x.core} feature is required for C6x
> +targets.
Same here: mention the full name in the text once.
What about NEWS? do we want this addition mentioned there?
> gdb/
> * features/Makefile (WHICH): Add tic6x-c64xp-linux tic6x-c64x-linux
> and tic6x-c62x-linux.
> * features/tic6x-c6xp.xml: New.
> * features/tic6x-core.xml: New.
> * features/tic6x-gp.xml: New.
> * features/tic6x-c62x-linux.xml: New.
> * features/tic6x-c64x-linux.xml: New.
> * features/tic6x-c64xp-linux.xml: New.
> * features/tic6x-c64xp-linux.c: Generated.
> * features/tic6x-c64x-linux.c: Generated.
> * features/tic6x-c62x-linux.c: Generated.
> * regformats/tic6x-c62x-linux.dat: Generated.
> * regformats/tic6x-c64x-linux.dat: Generated.
> * regformats/tic6x-c64xp-linux.dat: Generated.
Quite a few of these files will trigger ARI alerts about file-name
collisions on 8+3 filesystems. Please consider updating fnchange.lst.
next prev parent reply other threads:[~2011-07-27 5:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 2:12 Yao Qi
2011-07-20 18:22 ` Pedro Alves
2011-07-21 9:52 ` Yao Qi
2011-07-21 12:21 ` Pedro Alves
2011-07-25 7:27 ` Yao Qi
2011-07-26 18:18 ` Pedro Alves
2011-07-27 5:17 ` Yao Qi
2011-07-27 7:01 ` Eli Zaretskii [this message]
2011-07-27 8:08 ` Yao Qi
2011-07-27 10:43 ` Eli Zaretskii
2011-07-27 12:32 ` Yao Qi
2011-07-27 14:44 ` Eli Zaretskii
2011-07-27 6:19 ` Yao Qi
2011-07-21 14:04 ` Joseph S. Myers
2011-07-22 10:01 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1QlwUl-0001EN-PE@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox