From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5477 invoked by alias); 27 Jul 2011 05:17:41 -0000 Received: (qmail 5469 invoked by uid 22791); 27 Jul 2011 05:17:40 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 27 Jul 2011 05:17:26 +0000 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QlwUl-0001EN-PE; Wed, 27 Jul 2011 01:17:23 -0400 Date: Wed, 27 Jul 2011 07:01:00 -0000 Message-Id: From: Eli Zaretskii To: Yao Qi CC: pedro@codesourcery.com, gdb-patches@sourceware.org In-reply-to: <4E2F89D4.7050401@codesourcery.com> (message from Yao Qi on Wed, 27 Jul 2011 11:45:24 +0800) Subject: Re: [RFA 6/8] New port: TI C6x: gdbserver Reply-to: Eli Zaretskii References: <4E2638CE.7050205@codesourcery.com> <201107211213.41018.pedro@codesourcery.com> <4E2D18F3.6080006@codesourcery.com> <201107261844.13460.pedro@codesourcery.com> <4E2F89D4.7050401@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00751.txt.bz2 > Date: Wed, 27 Jul 2011 11:45:24 +0800 > From: Yao Qi > CC: gdb-patches@sourceware.org > > I've sorted this into alpha-beta order in new patch. Eli, could you > have a review on new document part in this patch? Here goes: > gdb/doc/ > * gdb.texinfo: Document C6x features. You need to state the name of the node here, see the other log entries. > +@node C6x Features > +@subsection C6x Features How about using a more full/explicit name of the target in the subsection name? After all, C6x is just an abbreviation/acronym. I would assume that users of these targets will at least expect to see something like TMS320C6x, if not "Texas Instruments". > +@cindex target descriptions, C6x features Same here: I would suggest an additional @cindex entry with the full name. > +The @samp{org.gnu.gdb.tic6x.core} feature is required for C6x > +targets. Same here: mention the full name in the text once. What about NEWS? do we want this addition mentioned there? > gdb/ > * features/Makefile (WHICH): Add tic6x-c64xp-linux tic6x-c64x-linux > and tic6x-c62x-linux. > * features/tic6x-c6xp.xml: New. > * features/tic6x-core.xml: New. > * features/tic6x-gp.xml: New. > * features/tic6x-c62x-linux.xml: New. > * features/tic6x-c64x-linux.xml: New. > * features/tic6x-c64xp-linux.xml: New. > * features/tic6x-c64xp-linux.c: Generated. > * features/tic6x-c64x-linux.c: Generated. > * features/tic6x-c62x-linux.c: Generated. > * regformats/tic6x-c62x-linux.dat: Generated. > * regformats/tic6x-c64x-linux.dat: Generated. > * regformats/tic6x-c64xp-linux.dat: Generated. Quite a few of these files will trigger ARI alerts about file-name collisions on 8+3 filesystems. Please consider updating fnchange.lst.