Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Joseph S. Myers" <joseph@codesourcery.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 6/8] New port: TI C6x: gdbserver
Date: Thu, 21 Jul 2011 14:04:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.64.1107211353530.11368@digraph.polyomino.org.uk> (raw)
In-Reply-To: <4E2638CE.7050205@codesourcery.com>

In this patch, and also in the main GDB port, I think you've used the 
wrong set of register names.  Specifically, it appears you used a list 
provided by TI on 22 September 2010 as an early draft of the list of DWARF 
register numbers for the ABI, which had a typo I pointed out the next day 
(NPR should be NRP) and was missing ECR (later inserted in the middle of 
the list) and various undocumented control registers (later added at the 
end).  You should check the list carefully against ABI version 0.9.  In 
addition, the XML files should reflect the different sets of registers on 
each processor variant (for details of what processors have what 
undocumented control registers, see the details TI provided on 29 October 
2010 - again, with a subsequent correction; the documented registers are 
covered in the ISA manuals or in 
include/opcode/tic6x-control-registers.h).

-- 
Joseph S. Myers
joseph@codesourcery.com


  parent reply	other threads:[~2011-07-21 14:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-20  2:12 Yao Qi
2011-07-20 18:22 ` Pedro Alves
2011-07-21  9:52   ` Yao Qi
2011-07-21 12:21     ` Pedro Alves
2011-07-25  7:27       ` Yao Qi
2011-07-26 18:18         ` Pedro Alves
2011-07-27  5:17           ` Yao Qi
2011-07-27  7:01             ` Eli Zaretskii
2011-07-27  8:08               ` Yao Qi
2011-07-27 10:43                 ` Eli Zaretskii
2011-07-27 12:32                   ` Yao Qi
2011-07-27 14:44                     ` Eli Zaretskii
2011-07-27  6:19           ` Yao Qi
2011-07-21 14:04 ` Joseph S. Myers [this message]
2011-07-22 10:01   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1107211353530.11368@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox