From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10792 invoked by alias); 21 Jul 2011 14:00:37 -0000 Received: (qmail 10780 invoked by uid 22791); 21 Jul 2011 14:00:36 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Jul 2011 14:00:02 +0000 Received: (qmail 17503 invoked from network); 21 Jul 2011 14:00:01 -0000 Received: from unknown (HELO digraph.polyomino.org.uk) (joseph@127.0.0.2) by mail.codesourcery.com with ESMTPA; 21 Jul 2011 14:00:01 -0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.72) (envelope-from ) id 1QjtnC-0003dh-PO; Thu, 21 Jul 2011 13:59:58 +0000 Date: Thu, 21 Jul 2011 14:04:00 -0000 From: "Joseph S. Myers" To: Yao Qi cc: gdb-patches@sourceware.org Subject: Re: [RFA 6/8] New port: TI C6x: gdbserver In-Reply-To: <4E2638CE.7050205@codesourcery.com> Message-ID: References: <4E2638CE.7050205@codesourcery.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-07/txt/msg00581.txt.bz2 In this patch, and also in the main GDB port, I think you've used the wrong set of register names. Specifically, it appears you used a list provided by TI on 22 September 2010 as an early draft of the list of DWARF register numbers for the ABI, which had a typo I pointed out the next day (NPR should be NRP) and was missing ECR (later inserted in the middle of the list) and various undocumented control registers (later added at the end). You should check the list carefully against ABI version 0.9. In addition, the XML files should reflect the different sets of registers on each processor variant (for details of what processors have what undocumented control registers, see the details TI provided on 29 October 2010 - again, with a subsequent correction; the documented registers are covered in the ISA manuals or in include/opcode/tic6x-control-registers.h). -- Joseph S. Myers joseph@codesourcery.com