From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-82637-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20674 invoked by alias); 26 Jul 2011 17:44:33 -0000
Received: (qmail 20657 invoked by uid 22791); 26 Jul 2011 17:44:32 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 26 Jul 2011 17:44:16 +0000
Received: (qmail 10251 invoked from network); 26 Jul 2011 17:44:15 -0000
Received: from unknown (HELO scottsdale.localnet) (pedro@127.0.0.2)  by mail.codesourcery.com with ESMTPA; 26 Jul 2011 17:44:15 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA 6/8] New port: TI C6x: gdbserver
Date: Tue, 26 Jul 2011 18:18:00 -0000
User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; )
Cc: Yao Qi <yao@codesourcery.com>
References: <4E2638CE.7050205@codesourcery.com> <201107211213.41018.pedro@codesourcery.com> <4E2D18F3.6080006@codesourcery.com>
In-Reply-To: <4E2D18F3.6080006@codesourcery.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201107261844.13460.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-07/txt/msg00732.txt.bz2

Thanks.  This code in this version looked good to me,
with a few nits pointed out below that I noticed this time
around.

The new docs bits will need to be reviewed by Eli.  I
have one comment to them:

> @@ -36854,6 +36854,7 @@ registers using the capitalization used in the description.
>  * MIPS Features::
>  * M68K Features::
>  * PowerPC Features::
> +* C6x Features::
>  @end menu

The list looked alpha sorted to me.



> +static int tic6x_regmap_c64x[] = {
> +  /* A0 - A15 */
> +  51, 50, 53, 52, 55, 54, 57, 56,
> +  59, 58, 61, 60, 63, 62, 65, 64,
> +  /* B0 - B15 */
> +  21, 20, 23, 22, 25, 24, 27, 26,
> +  29, 28, 31, 30, 33, 32, 67, 66,
> +  /* CSR PC */
> +  3, 2,
> +  /* A16 - A31 */
> +  35, 34, 37, 36, 39, 38, 41, 40,
> +  43, 42, 45, 44, 47, 46, 49, 48,
> +  /* B16 - B32 */

B31, I think?

> +  5,  4,  7,  6,  9,  8,  11, 10,
> +  13, 12, 15, 14, 17, 16, 19, 18,
> +  -1, -1, -1

> +  /* CSR PC*/

Missing space. (several places)

> +  *base = (void *) ((char *)*base - idx);

Missing space after (char *)

> +#ifdef HAVE_PTRACE_GETREGS
> +

I wonder if there ever was a c6x kernel that
didn't have this.

-- 
Pedro Alves