[patch 1/2] Code cleanup: New symbol_filename_ftype

[patch 1/2] Code cleanup: New symbol_filename_ftype

[Jan Kratochvil]

Hi,

no code change, either I could use filename + fullname names everywhere or
- I used - the typedef where one can jump to.

I will check it in less than a week.


Thanks,
Jan


gdb/
2011-06-10  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Code cleanup.
	* dwarf2read.c (dw2_map_symbol_filenames): Use symbol_filename_ftype
	for fun.
	* psymtab.c (map_symbol_filenames_psymtab)
	(map_partial_symbol_filenames): Likewise.
	* psymtab.h: Include symfile.h.
	(map_partial_symbol_filenames): Use symbol_filename_ftype for fun.
	* symfile.h (symbol_filename_ftype): New.
	(struct quick_symbol_functions): Use symbol_filename_ftype for fun of
	map_symbol_filenames, clarify more the naming in comment.

--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -2720,8 +2720,7 @@ dw2_find_pc_sect_symtab (struct objfile *objfile,
 }
 
 static void
-dw2_map_symbol_filenames (struct objfile *objfile,
-			  void (*fun) (const char *, const char *, void *),
+dw2_map_symbol_filenames (struct objfile *objfile, symbol_filename_ftype *fun,
 			  void *data)
 {
   int i;
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -1082,9 +1082,7 @@ read_psymtabs_with_filename (struct objfile *objfile, const char *filename)
 
 static void
 map_symbol_filenames_psymtab (struct objfile *objfile,
-			      void (*fun) (const char *, const char *,
-					   void *),
-			      void *data)
+			      symbol_filename_ftype *fun, void *data)
 {
   struct partial_symtab *ps;
 
@@ -1917,9 +1915,7 @@ expand_partial_symbol_names (int (*fun) (const char *, void *), void *data)
 }
 
 void
-map_partial_symbol_filenames (void (*fun) (const char *, const char *,
-					   void *),
-			      void *data)
+map_partial_symbol_filenames (symbol_filename_ftype *fun, void *data)
 {
   struct objfile *objfile;
 
--- a/gdb/psymtab.h
+++ b/gdb/psymtab.h
@@ -20,6 +20,8 @@
 #ifndef PSYMTAB_H
 #define PSYMTAB_H
 
+#include "symfile.h"
+
 /* A bcache for partial symbols.  */
 
 struct psymbol_bcache;
@@ -31,9 +33,7 @@ extern struct bcache *psymbol_bcache_get_bcache (struct psymbol_bcache *);
 void expand_partial_symbol_names (int (*fun) (const char *, void *),
 				  void *data);
 
-void map_partial_symbol_filenames (void (*) (const char *, const char *,
-					     void *),
-				   void *);
+void map_partial_symbol_filenames (symbol_filename_ftype *fun, void *data);
 
 extern const struct quick_symbol_functions psym_functions;
 
--- a/gdb/symfile.h
+++ b/gdb/symfile.h
@@ -116,6 +116,11 @@ struct symfile_segment_data
   int *segment_info;
 };
 
+/* Callback for quick_symbol_functions->map_symbol_filenames.  */
+
+typedef void (symbol_filename_ftype) (const char *filename,
+				      const char *fullname, void *data);
+
 /* The "quick" symbol functions exist so that symbol readers can
    avoiding an initial read of all the symbols.  For example, symbol
    readers might choose to use the "partial symbol table" utilities,
@@ -283,12 +288,10 @@ struct quick_symbol_functions
 					 int warn_if_readin);
 
   /* Call a callback for every file defined in OBJFILE whose symtab is
-     not already read in.  FUN is the callback.  It is passed the file's name,
-     the file's full name, and the DATA passed to this function.  */
+     not already read in.  FUN is the callback.  It is passed the file's
+     FILENAME, the file's FULLNAME, and the DATA passed to this function.  */
   void (*map_symbol_filenames) (struct objfile *objfile,
-				void (*fun) (const char *, const char *,
-					     void *),
-				void *data);
+				symbol_filename_ftype *fun, void *data);
 };
 
 /* Structure to keep track of symbol reading functions for various

Re: [patch 1/2] Code cleanup: New symbol_filename_ftype

[Tom Tromey]

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> no code change, either I could use filename + fullname names everywhere or
Jan> - I used - the typedef where one can jump to.

Jan> I will check it in less than a week.

Looks good to me.

Jan> 	Code cleanup.
Jan> 	* dwarf2read.c (dw2_map_symbol_filenames): Use symbol_filename_ftype
Jan> 	for fun.

Funny but also accurate!

Tom

Re: [patch 1/2] Code cleanup: New symbol_filename_ftype

[Joel Brobecker]

> I will check it in less than a week.

I'd just go ahead and check in now. Patches like these are great, IMO.
Note that it gives us an opportunity to document the meaning of the
various parameters (I am also a fan of naming the parameters in
declarations as well, as Jan did here).

> gdb/
> 2011-06-10  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Code cleanup.
> 	* dwarf2read.c (dw2_map_symbol_filenames): Use symbol_filename_ftype
> 	for fun.
> 	* psymtab.c (map_symbol_filenames_psymtab)
> 	(map_partial_symbol_filenames): Likewise.
> 	* psymtab.h: Include symfile.h.
> 	(map_partial_symbol_filenames): Use symbol_filename_ftype for fun.
> 	* symfile.h (symbol_filename_ftype): New.
> 	(struct quick_symbol_functions): Use symbol_filename_ftype for fun of
> 	map_symbol_filenames, clarify more the naming in comment.

Looks good to me.

-- 
Joel

Re: [patch 1/2] Code cleanup: New symbol_filename_ftype

[Jan Kratochvil]

On Fri, 10 Jun 2011 22:55:22 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> Jan> 	Code cleanup.
> Jan> 	* dwarf2read.c (dw2_map_symbol_filenames): Use symbol_filename_ftype
> Jan> 	for fun.
> 
> Funny but also accurate!

:-)


On Fri, 10 Jun 2011 22:55:22 +0200, Tom Tromey wrote:
> Looks good to me.
On Fri, 10 Jun 2011 23:24:00 +0200, Joel Brobecker wrote:
> Looks good to me.

Checked in:
	http://sourceware.org/ml/gdb-cvs/2011-06/msg00055.html


Thanks,
Jan