From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-81543-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25020 invoked by alias); 10 Jun 2011 20:55:45 -0000
Received: (qmail 25010 invoked by uid 22791); 10 Jun 2011 20:55:44 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_FILL_THIS_FORM_SHORT,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 20:55:24 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p5AKtObD015525	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 10 Jun 2011 16:55:24 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p5AKtNfc021021;	Fri, 10 Jun 2011 16:55:24 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p5AKtN48002191;	Fri, 10 Jun 2011 16:55:23 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id EDC08378219; Fri, 10 Jun 2011 14:55:22 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch 1/2] Code cleanup: New symbol_filename_ftype
References: <20110610202912.GA31746@host1.jankratochvil.net>
Date: Fri, 10 Jun 2011 20:55:00 -0000
In-Reply-To: <20110610202912.GA31746@host1.jankratochvil.net> (Jan	Kratochvil's message of "Fri, 10 Jun 2011 22:29:12 +0200")
Message-ID: <m3sjrh8kzp.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-06/txt/msg00141.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> no code change, either I could use filename + fullname names everywhere or
Jan> - I used - the typedef where one can jump to.

Jan> I will check it in less than a week.

Looks good to me.

Jan> 	Code cleanup.
Jan> 	* dwarf2read.c (dw2_map_symbol_filenames): Use symbol_filename_ftype
Jan> 	for fun.

Funny but also accurate!

Tom